feat: Certify Charts and Dashboards by geido · Pull Request #17335 · apache/superset

geido · 2021-11-03T17:00:33Z

SUMMARY

This PR:

Allows to certify Charts and Dashboard and filter them out
Refactors the Explore/PropertiesModal to use the built-in Antd form functionalities instead of polluting the state

AFTER

DEV.Superset.2.mp4

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

…e/certified_dashboards_charts

codecov · 2021-11-09T14:39:12Z

Codecov Report

Merging #17335 (ee6e7ab) into master (c54027a) will decrease coverage by 0.19%.
The diff coverage is 89.53%.

❗ Current head ee6e7ab differs from pull request most recent head 082ef5a. Consider uploading reports for the commit 082ef5a to get more accurate results

@@            Coverage Diff             @@
##           master   #17335      +/-   ##
==========================================
- Coverage   76.94%   76.75%   -0.20%     
==========================================
  Files        1042     1042              
  Lines       56299    56364      +65     
  Branches     7793     7815      +22     
==========================================
- Hits        43322    43262      -60     
- Misses      12721    12846     +125     
  Partials      256      256

Flag	Coverage Δ
hive	`?`
javascript	`71.06% <84.78%> (+0.02%)`	⬆️
presto	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...perset-frontend/src/views/CRUD/chart/ChartCard.tsx	`75.60% <ø> (ø)`
...rontend/src/views/CRUD/dashboard/DashboardCard.tsx	`77.77% <ø> (ø)`
superset-frontend/src/views/CRUD/hooks.ts	`52.76% <ø> (ø)`
superset-frontend/src/views/CRUD/types.ts	`100.00% <ø> (ø)`
superset/dashboards/api.py	`93.03% <ø> (ø)`
...frontend/src/dashboard/components/Header/index.jsx	`68.64% <50.00%> (-0.21%)`	⬇️
...rontend/src/views/CRUD/dashboard/DashboardList.tsx	`71.14% <50.00%> (-1.09%)`	⬇️
...set-frontend/src/components/ListViewCard/index.tsx	`98.18% <66.66%> (-1.82%)`	⬇️
...perset-frontend/src/views/CRUD/chart/ChartList.tsx	`74.21% <66.66%> (-0.15%)`	⬇️
...rc/explore/components/ExploreChartHeader/index.jsx	`57.29% <83.33%> (+0.76%)`	⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c54027a...082ef5a. Read the comment docs.

geido · 2021-11-10T13:42:25Z

/testenv up

zhaoyongjie

codes LGTM, except certificated_by column type.

betodealmeida

We have a script to benchmark DB migations, can you run it with your migration and post the results?

https://github.com/apache/superset/blob/master/scripts/benchmark_migration.py

betodealmeida · 2021-11-12T17:05:40Z

+
+def upgrade():
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.add_column("dashboards", sa.Column("certified_by", sa.Text(), nullable=True))


Can you use op.batch_alter_table here and in the downgrade? Some databases don't support adding/removing columns, so you need to use op.batch_alter_table to make the migration work with them. You can find examples in the other migration scripts.

github-actions · 2021-11-14T17:58:01Z

⚠️ @geido Your base branch master has just also updated superset/migrations.

❗ Please consider rebasing your branch to avoid db migration conflicts.

…e/certified_dashboards_charts

geido · 2021-11-17T12:29:32Z

Hey @betodealmeida I applied your suggested changes and ran the benchmarks as follows:

aea15018d53b_add_certifications_columns_to_dashboard.py

Current: 0.22 s
10+: 0.25 s
100+: 0.52 s
1000+: 0.21 s

f9847149153d_add_certifications_columns_to_slice.py

Current: 0.25 s
10+: 0.23 s
100+: 0.47 s
1000+: 0.22 s

betodealmeida

Thanks for the migration benchmark!

github-actions · 2021-11-24T11:43:14Z

Ephemeral environment shutdown and build artifacts deleted.

* Certify charts * Format * Certify dashboards * Format * Refactor card certification * Clear details when certified by empty * Show certification in detail page * Add RTL tests * Test charts api * Enhance integration tests * Lint * Fix dashboards count * Format * Handle empty value * Handle empty slice * Downgrade migration * Indent * Use alter * Fix revision * Fix revision

Certify charts

a0164e9

superset-github-bot Bot added the Flexiana label Nov 3, 2021

pull-request-size Bot added the size/L label Nov 3, 2021

Format

b6e35ca

geido changed the title ~~feat: Certify charts~~ feat: Certify Charts and Dashboards Nov 5, 2021

geido added 7 commits November 5, 2021 10:53

Improve UI

242cb61

Certify dashboards

4e5ff07

Format

07b96ca

Refactor card certification

bafd7f5

Clear details when certified by empty

4c4e049

Show certification in detail page

0943197

Add RTL tests

b63067a

pull-request-size Bot added size/XL and removed size/L labels Nov 5, 2021

geido added 2 commits November 5, 2021 16:05

Test charts api

a72a3d7

Enhance integration tests

53d4f12

geido marked this pull request as ready for review November 5, 2021 17:58

geido requested a review from a team as a code owner November 5, 2021 17:58

Lint

93698c4

geido requested review from pkdotson, rusackas, villebro and zhaoyongjie November 5, 2021 18:16

geido added 4 commits November 5, 2021 18:20

Fix dashboards count

895e342

Format

a59143b

Merge branch 'master' of https://github.com/apache/superset into chor…

d75caa4

…e/certified_dashboards_charts

Handle empty value

6e81002

Handle empty slice

4889896

zhaoyongjie reviewed Nov 12, 2021

View reviewed changes

Comment thread superset/migrations/versions/aea15018d53b_add_certifications_columns_to_dashboard.py Outdated

geido added 3 commits November 12, 2021 15:43

Resolve conflict

ba4fe16

Downgrade migration

b480283

Indent

afe39a8

zhaoyongjie approved these changes Nov 12, 2021

View reviewed changes

betodealmeida requested changes Nov 12, 2021

View reviewed changes

betodealmeida added the risk:db-migration PRs that require a DB migration label Nov 12, 2021

geido added 5 commits November 16, 2021 15:58

Use alter

ce1f7c8

Merge branch 'master' of https://github.com/apache/superset into chor…

d318f13

…e/certified_dashboards_charts

Fix revision

bbc7092

Fix revision

fb3c2a3

Merge branch 'master' of https://github.com/apache/superset into chor…

082ef5a

…e/certified_dashboards_charts

rusackas requested a review from betodealmeida November 22, 2021 06:40

betodealmeida approved these changes Nov 22, 2021

View reviewed changes

geido merged commit 83e49fc into apache:master Nov 24, 2021

amitmiran137 added the v1.4 label Dec 21, 2021

siegfriedweber mentioned this pull request Feb 9, 2022

Add Superset 1.4.1 stackabletech/docker-images#47

Closed

mistercrunch added 🍒 1.4.0 Cherry-picked to 1.4.0 🍒 1.4.1 Cherry-picked to 1.4.1 🍒 1.4.2 Cherry-picked to 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 First shipped in 1.5.0 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Certify Charts and Dashboards#17335

feat: Certify Charts and Dashboards#17335
geido merged 25 commits into
apache:masterfrom
geido:chore/certified_dashboards_charts

geido commented Nov 3, 2021 •

edited by betodealmeida

Loading

Uh oh!

codecov Bot commented Nov 9, 2021 •

edited

Loading

Uh oh!

geido commented Nov 10, 2021

Uh oh!

Uh oh!

zhaoyongjie left a comment

Uh oh!

betodealmeida left a comment

Uh oh!

betodealmeida Nov 12, 2021

Uh oh!

github-actions Bot commented Nov 14, 2021

Uh oh!

geido commented Nov 17, 2021 •

edited

Loading

Uh oh!

betodealmeida left a comment

Uh oh!

github-actions Bot commented Nov 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

geido commented Nov 3, 2021 • edited by betodealmeida Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

AFTER

ADDITIONAL INFORMATION

Uh oh!

codecov Bot commented Nov 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

geido commented Nov 10, 2021

Uh oh!

Uh oh!

zhaoyongjie left a comment

Choose a reason for hiding this comment

Uh oh!

betodealmeida left a comment

Choose a reason for hiding this comment

Uh oh!

betodealmeida Nov 12, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Nov 14, 2021

Uh oh!

geido commented Nov 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

betodealmeida left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Nov 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

geido commented Nov 3, 2021 •

edited by betodealmeida

Loading

codecov Bot commented Nov 9, 2021 •

edited

Loading

geido commented Nov 17, 2021 •

edited

Loading