Skip to content

fix: Removes duplicated import in dashboard filter state tests#17887

Merged
michael-s-molina merged 1 commit into
apache:masterfrom
michael-s-molina:remove-duplicated-import
Dec 29, 2021
Merged

fix: Removes duplicated import in dashboard filter state tests#17887
michael-s-molina merged 1 commit into
apache:masterfrom
michael-s-molina:remove-duplicated-import

Conversation

@michael-s-molina
Copy link
Copy Markdown
Member

SUMMARY

Removes duplicated import in dashboard filter state tests.

TESTING INSTRUCTIONS

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 29, 2021

Codecov Report

Merging #17887 (24e4f5d) into master (ef57bd1) will not change coverage.
The diff coverage is n/a.

❗ Current head 24e4f5d differs from pull request most recent head 016e65c. Consider uploading reports for the commit 016e65c to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17887   +/-   ##
=======================================
  Coverage   66.91%   66.91%           
=======================================
  Files        1609     1609           
  Lines       64897    64897           
  Branches     6866     6866           
=======================================
  Hits        43426    43426           
  Misses      19605    19605           
  Partials     1866     1866           
Flag Coverage Δ
mysql 82.19% <ø> (ø)
postgres 82.24% <ø> (ø)
python 82.32% <ø> (ø)
sqlite 81.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/async_query_manager.py 82.24% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef57bd1...016e65c. Read the comment docs.

@mayurnewase
Copy link
Copy Markdown
Contributor

thanks, now that hook is working properly lol, and is already fixed in #17886
you may wanna rebase this on master.

@michael-s-molina michael-s-molina merged commit 8ebec60 into apache:master Dec 29, 2021
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 First shipped in 1.5.0 labels Mar 13, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0 First shipped in 1.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants