fix(echarts): Area Chart regression — bumping to 0.18.22 for v1.4.x#18204
Closed
rusackas wants to merge 1 commit into
Closed
fix(echarts): Area Chart regression — bumping to 0.18.22 for v1.4.x#18204rusackas wants to merge 1 commit into
rusackas wants to merge 1 commit into
Conversation
9 tasks
villebro
reviewed
Jan 27, 2022
| "@superset-ui/legacy-preset-chart-deckgl": "^0.4.13", | ||
| "@superset-ui/legacy-preset-chart-nvd3": "^0.18.19", | ||
| "@superset-ui/plugin-chart-echarts": "^0.18.19", | ||
| "@superset-ui/plugin-chart-echarts": "^0.18.22", |
Member
There was a problem hiding this comment.
I'm not sure we can do a surgical bump of @superset-ui/plugin-chart-echarts from 0.18.19 to 0.18.22 without also bumping all other @superset-ui packages, as it will cause two different versions of @superset-ui/core to be installed. The only viable option I can think of is to pull in the following superset-ui bumps that will end up bringing in that missing cherry:
Member
There was a problem hiding this comment.
superset-ui/plugin-chart-echarts depends on superset-ui/core 0.18.22 https://github.com/apache-superset/superset-ui/blob/v0.18.22/plugins/plugin-chart-echarts/package.json
Can we release a post-monorepo release to resolve this issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Attempting to resolve #18129 by bumping the Echarts package to 0.18.22.
Note that
masterhas moved on to monorepo since that release was cut, so this is a little wierdBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:

After:

TESTING INSTRUCTIONS
ADDITIONAL INFORMATION