feat: Improves key expiration handling in Explore

[michael-s-molina]

SUMMARY

The objective of this PR is to improve Explore handling when a form_data_key expires. Previously when a key expired, the user was presented with the following screen:

To avoid this situation this PR introduces two new query parameters called slice_id and dataset_id. These parameters are used when processing an Explore request in case the form_data_key is expired. In this scenario, we recover with the minimal information necessary to present the chart, dealing with both saved and unsaved charts.

In the video below I simulate a key expiration by disabling the cache and demonstrate the changes in the workflow:

Screen.Recording.2022-02-08.at.1.42.38.PM.mov

TESTING INSTRUCTIONS

Check the video for instructions.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #18624 (5cc859b) into master (1fbdabd) will decrease coverage by 0.01%.
The diff coverage is 42.85%.

❗ Current head 5cc859b differs from pull request most recent head ad6781a. Consider uploading reports for the commit ad6781a to get more accurate results

@@            Coverage Diff             @@
##           master   #18624      +/-   ##
==========================================
- Coverage   66.30%   66.29%   -0.02%     
==========================================
  Files        1595     1595              
  Lines       62632    62612      -20     
  Branches     6309     6306       -3     
==========================================
- Hits        41529    41506      -23     
- Misses      19453    19458       +5     
+ Partials     1650     1648       -2     

Flag	Coverage Δ
hive	52.06% <0.00%> (-0.02%)	⬇️
javascript	51.32% <28.57%> (-0.05%)	⬇️
mysql	81.24% <71.42%> (-0.01%)	⬇️
postgres	81.29% <71.42%> (-0.01%)	⬇️
presto	51.90% <0.00%> (-0.02%)	⬇️
python	81.72% <71.42%> (-0.01%)	⬇️
sqlite	80.98% <71.42%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../src/dashboard/components/gridComponents/Chart.jsx	58.88% <0.00%> (ø)
...re/components/controls/DatasourceControl/index.jsx	72.36% <12.50%> (-5.90%)	⬇️
.../explore/components/ExploreViewContainer/index.jsx	56.98% <50.00%> (-0.16%)	⬇️
superset/views/core.py	77.56% <71.42%> (-0.04%)	⬇️
...dashboard/components/menu/ShareMenuItems/index.tsx	65.38% <100.00%> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js	60.39% <0.00%> (ø)
...frontend/src/SqlLab/components/ResultSet/index.tsx	50.73% <0.00%> (ø)
...c/SqlLab/components/ExploreResultsButton/index.jsx
.../src/explore/components/controls/BoundsControl.jsx
.../src/explore/components/controls/BoundsControl.tsx	88.88% <0.00%> (ø)
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fbdabd...ad6781a. Read the comment docs.

[villebro]

One comment relating to making the fallback more transparent to the user. But beyond that, really great improvement! 🚀

[zhaoyongjie]

Thanks for the fix. LGTM

[villebro]

LGTM!

[ktmud]

I'm wondering if we can encode the slice and dataset ids directly in the URL path. I.e., the explore URL becomes /explore/s/{slice_id}/{form_data_key} or /explore/d/{dataset_id}/{form_data_key}