Skip to content

fix(cache): only warn about fallback cache for non-debug mode#19305

Merged
villebro merged 1 commit into
apache:masterfrom
preset-io:villebro/fix-cache-warning
Mar 22, 2022
Merged

fix(cache): only warn about fallback cache for non-debug mode#19305
villebro merged 1 commit into
apache:masterfrom
preset-io:villebro/fix-cache-warning

Conversation

@villebro
Copy link
Copy Markdown
Member

SUMMARY

#19232 introduced a new default cache based on the key value table in the metadata database. To avoid triggering the warning when running in development/debug mode, this PR adds a check to skip the warning if the application is running in debug mode.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Copy Markdown
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 7ca10fb into apache:master Mar 22, 2022
michael-hoffman-26 pushed a commit to nielsen-oss/superset that referenced this pull request Mar 23, 2022
villebro added a commit that referenced this pull request Apr 3, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 Cherry-picked to 1.5.0 🍒 1.5.1 Cherry-picked to 1.5.1 🍒 1.5.2 Cherry-picked to 1.5.2 🍒 1.5.3 Cherry-picked to 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 First shipped in 2.0.0 labels Mar 13, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset-io size/XS 🍒 1.5.0 Cherry-picked to 1.5.0 🍒 1.5.1 Cherry-picked to 1.5.1 🍒 1.5.2 Cherry-picked to 1.5.2 🍒 1.5.3 Cherry-picked to 1.5.3 🚢 2.0.0 First shipped in 2.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants