fix(post_processing): remove indices from csv output#19735
Closed
cemremengu wants to merge 1 commit into
Closed
Conversation
This PR removes the pseudo range index added in post_processing when converting to csv. When sending reports as csv or inline text, this id is also included. I believe it does not add any value to output however if it is somehow useful, it is better to include it either via query or make it optional.
Codecov Report
@@ Coverage Diff @@
## master #19735 +/- ##
==========================================
+ Coverage 66.48% 66.51% +0.02%
==========================================
Files 1686 1686
Lines 64588 64585 -3
Branches 6636 6636
==========================================
+ Hits 42942 42958 +16
+ Misses 19947 19928 -19
Partials 1699 1699
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR removes the pseudo range index added in post_processing when converting to csv.
When sending reports as csv or inline text, this id is also included. I believe it does not add any value to output however if it is somehow useful, it is better to include it either via query or make it optional.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
ADDITIONAL INFORMATION