Skip to content

feat(superset-ui-core): add feature flag for the analogous colors#19987

Merged
stephenLYZ merged 3 commits into
apache:masterfrom
stephenLYZ:feat-color-analogous-ff
Jun 3, 2022
Merged

feat(superset-ui-core): add feature flag for the analogous colors#19987
stephenLYZ merged 3 commits into
apache:masterfrom
stephenLYZ:feat-color-analogous-ff

Conversation

@stephenLYZ
Copy link
Copy Markdown
Member

@stephenLYZ stephenLYZ commented May 8, 2022

SUMMARY

This PR adds a FEATURE_FLAG for USE_ANALAGOUS_COLORS which, when enabled, would act as it does today. If you turn it off, it would simply loop through the palette colors repeatedly. Default is True. refer to #19038 (comment).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2022

Codecov Report

Merging #19987 (41e2faa) into master (d7e3ac3) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

❗ Current head 41e2faa differs from pull request most recent head 91d4046. Consider uploading reports for the commit 91d4046 to get more accurate results

@@            Coverage Diff             @@
##           master   #19987      +/-   ##
==========================================
- Coverage   66.46%   66.41%   -0.06%     
==========================================
  Files        1721     1719       -2     
  Lines       64517    64346     -171     
  Branches     6807     6723      -84     
==========================================
- Hits        42879    42733     -146     
+ Misses      19906    19902       -4     
+ Partials     1732     1711      -21     
Flag Coverage Δ
hive 53.72% <53.84%> (-0.01%) ⬇️
mysql 82.14% <76.92%> (-0.01%) ⬇️
postgres 82.20% <76.92%> (-0.01%) ⬇️
presto ?
python 82.51% <76.92%> (-0.12%) ⬇️
sqlite 81.94% <76.92%> (-0.01%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
...hart-pivot-table/src/react-pivottable/utilities.js 0.00% <0.00%> (ø)
...c/SqlLab/components/ExploreResultsButton/index.tsx 100.00% <ø> (ø)
...ts/nativeFilters/FilterBar/ActionButtons/index.tsx 85.71% <ø> (ø)
.../src/explore/components/ControlPanelsContainer.tsx 79.80% <ø> (ø)
superset/config.py 91.41% <ø> (ø)
...end/src/dashboard/components/SliceHeader/index.tsx 87.23% <50.00%> (ø)
superset/datasets/filters.py 86.95% <70.00%> (-13.05%) ⬇️
...et-frontend/src/components/EditableTitle/index.tsx 70.00% <75.00%> (ø)
...uperset-ui-core/src/color/CategoricalColorScale.ts 100.00% <100.00%> (ø)
... and 144 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7e3ac3...91d4046. Read the comment docs.

@geido geido requested a review from jinghua-qa June 3, 2022 07:31
@geido
Copy link
Copy Markdown
Member

geido commented Jun 3, 2022

/testenv up FEATURE_USE_ANALAGOUS_COLORS=false

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2022

@geido Ephemeral environment spinning up at http://54.185.1.3:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Copy Markdown
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@stephenLYZ stephenLYZ merged commit 80b5578 into apache:master Jun 3, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2022

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 First shipped in 2.0.0 labels Mar 13, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
…ache#19987)

* feat(superset-ui-core): add feature flag for the color analogous generator

* fix: test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.0.0 First shipped in 2.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants