feat(Helm Chart): Support resource limits and requests for each component#20052
Merged
craig-rueda merged 3 commits intoMay 25, 2022
Conversation
Member
|
Pls bump the chart version |
Contributor
Author
|
@craig-rueda I bumped the chart version |
dpgaspar
approved these changes
May 25, 2022
craig-rueda
approved these changes
May 25, 2022
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
2 tasks
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
We implemented the possibility to set individual resource limitations for every Superset component including supersetNode, supersetWorker and supersetCeleryBeat. For this reason, we added the values supersetNode.resources, supersetWorker.resources and supersetCeleryBeat.resources to the values file, the Helm Schema and the Helm Templates. These pod specific values overwrite the global resource limits and requests set via the values resources. This feature introduction will not break current deployments using the value resources and only implement additional functionality.
This change allows for a more customizable experience and a more optimized user experience when deploying Superset using the Helm Chart.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Using the command Helm template it is possible to verify if the resources limit and requests are set correctly.
ADDITIONAL INFORMATION