Using setup.py nosetests to run tests#202
Merged
Merged
Conversation
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 4, 2021
BREAKING CHANGE: No longer accept chartProps as a single prop in <SuperChart>. Developers must specify each field in chartProps individually.
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
BREAKING CHANGE: No longer accept chartProps as a single prop in <SuperChart>. Developers must specify each field in chartProps individually.
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
BREAKING CHANGE: No longer accept chartProps as a single prop in <SuperChart>. Developers must specify each field in chartProps individually.
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
BREAKING CHANGE: No longer accept chartProps as a single prop in <SuperChart>. Developers must specify each field in chartProps individually.
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
BREAKING CHANGE: No longer accept chartProps as a single prop in <SuperChart>. Developers must specify each field in chartProps individually.
mistercrunch
added
🏷️ bot
mikebridge
pushed a commit
to mikebridge/superset
that referenced
this pull request
Apr 28, 2026
Three fixes from kgabryje's review on PR apache#39641: 1. TextAreaControl IME guard double-fire on Firefox/Edge. Per W3C uievents apache#202, Firefox/Edge fire a synthetic onChange after compositionend with the committed value. Add a one-shot `justComposed` flag, cleared on the next change, so the committed value isn't propagated twice on those browsers. 2. DatasourceEditor onBlur defeated debounce for intra-form navigation. React onBlur bubbles, so tabbing between fields inside the container fired the synchronous flush on every focus change. Guard with `e.relatedTarget` so flushValidation only fires when focus actually leaves the container. 3. Drop `destroyInactiveTabPane`. The lazy-mount benefit isn't worth the UX regression of losing CollectionTable local state (search term, pagination, expanded rows) on every tab switch. The remaining fixes (debounce, memoised derived arrays, stable handler identity, IME guards) carry the perf wins. The .cancel()-vs-.flush() review point requires a deeper refactor of validate() to expose a sync compute path that doesn't depend on the component's setState. Deferred to a follow-up commit. Tests: 51/51 across 6 suites pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mikebridge
pushed a commit
to mikebridge/superset
that referenced
this pull request
Apr 28, 2026
Three fixes from kgabryje's review on PR apache#39641: 1. TextAreaControl IME guard double-fire on Firefox/Edge. Per W3C uievents apache#202, Firefox/Edge fire a synthetic onChange after compositionend with the committed value. Add a one-shot `justComposed` flag, cleared on the next change, so the committed value isn't propagated twice on those browsers. 2. DatasourceEditor onBlur defeated debounce for intra-form navigation. React onBlur bubbles, so tabbing between fields inside the container fired the synchronous flush on every focus change. Guard with `e.relatedTarget` so flushValidation only fires when focus actually leaves the container. 3. Drop `destroyInactiveTabPane`. The lazy-mount benefit isn't worth the UX regression of losing CollectionTable local state (search term, pagination, expanded rows) on every tab switch. The remaining fixes (debounce, memoised derived arrays, stable handler identity, IME guards) carry the perf wins. The .cancel()-vs-.flush() review point requires a deeper refactor of validate() to expose a sync compute path that doesn't depend on the component's setState. Deferred to a follow-up commit. Tests: 51/51 across 6 suites pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mikebridge
pushed a commit
to mikebridge/superset
that referenced
this pull request
Apr 28, 2026
Three fixes from kgabryje's review on PR apache#39641: 1. TextAreaControl IME guard double-fire on Firefox/Edge. Per W3C uievents apache#202, Firefox/Edge fire a synthetic onChange after compositionend with the committed value. Add a one-shot `justComposed` flag, cleared on the next change, so the committed value isn't propagated twice on those browsers. 2. DatasourceEditor onBlur defeated debounce for intra-form navigation. React onBlur bubbles, so tabbing between fields inside the container fired the synchronous flush on every focus change. Guard with `e.relatedTarget` so flushValidation only fires when focus actually leaves the container. 3. Drop `destroyInactiveTabPane`. The lazy-mount benefit isn't worth the UX regression of losing CollectionTable local state (search term, pagination, expanded rows) on every tab switch. The remaining fixes (debounce, memoised derived arrays, stable handler identity, IME guards) carry the perf wins. The .cancel()-vs-.flush() review point requires a deeper refactor of validate() to expose a sync compute path that doesn't depend on the component's setState. Deferred to a follow-up commit. Tests: 51/51 across 6 suites pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mikebridge
pushed a commit
to mikebridge/superset
that referenced
this pull request
Apr 29, 2026
Three fixes from kgabryje's review on PR apache#39641: 1. TextAreaControl IME guard double-fire on Firefox/Edge. Per W3C uievents apache#202, Firefox/Edge fire a synthetic onChange after compositionend with the committed value. Add a one-shot `justComposed` flag, cleared on the next change, so the committed value isn't propagated twice on those browsers. 2. DatasourceEditor onBlur defeated debounce for intra-form navigation. React onBlur bubbles, so tabbing between fields inside the container fired the synchronous flush on every focus change. Guard with `e.relatedTarget` so flushValidation only fires when focus actually leaves the container. 3. Drop `destroyInactiveTabPane`. The lazy-mount benefit isn't worth the UX regression of losing CollectionTable local state (search term, pagination, expanded rows) on every tab switch. The remaining fixes (debounce, memoised derived arrays, stable handler identity, IME guards) carry the perf wins. The .cancel()-vs-.flush() review point requires a deeper refactor of validate() to expose a sync compute path that doesn't depend on the component's setState. Deferred to a follow-up commit. Tests: 51/51 across 6 suites pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
Using setup.py nosetests to run tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.