“results” should be more fine grained w/ access checks as sql_json#2038
Closed
wyndhblb wants to merge 12 commits into
Closed
“results” should be more fine grained w/ access checks as sql_json#2038wyndhblb wants to merge 12 commits into
wyndhblb wants to merge 12 commits into
Conversation
added 12 commits
January 24, 2017 11:13
print("GIT SHA: " + GIT_SHA)
TypeError: Can't convert 'NoneType' object to str implicitly
Member
Contributor
Author
|
yes it does looks like a similar thing. From my previous PR #2034 i was trying to figure out why it was all failing. |
Member
|
There's a lot of improvments in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
“results” should be more fine grained w/ access checks as sql_json not just full DB access.
Otherwise the async queries for users limited to either certain schemas or tables from a DB can never see the results. Since the query info is also in the result payload, we can determine the same access rights from it.