Skip to content

“results” should be more fine grained w/ access checks as sql_json#2038

Closed
wyndhblb wants to merge 12 commits into
apache:masterfrom
wyndhblb:check_results_perms
Closed

“results” should be more fine grained w/ access checks as sql_json#2038
wyndhblb wants to merge 12 commits into
apache:masterfrom
wyndhblb:check_results_perms

Conversation

@wyndhblb
Copy link
Copy Markdown
Contributor

“results” should be more fine grained w/ access checks as sql_json not just full DB access.
Otherwise the async queries for users limited to either certain schemas or tables from a DB can never see the results. Since the query info is also in the result payload, we can determine the same access rights from it.

@bkyryliuk
Copy link
Copy Markdown
Member

@wyndhblb - I think we wrote the PRs almost at the same time,
#2032 - updates the permission check, I plan to merge it some time tomorrow.

@wyndhblb
Copy link
Copy Markdown
Contributor Author

yes it does looks like a similar thing. From my previous PR #2034 i was trying to figure out why it was all failing.

@mistercrunch
Copy link
Copy Markdown
Member

There's a lot of improvments in deprecate_v1 that should address this. Closing for now, reopen if I'm missing something after merging that PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants