refactor: Remove obsolete HiveEngineSpec.fetch_logs method#20631
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20631 +/- ##
==========================================
+ Coverage 65.76% 66.56% +0.80%
==========================================
Files 1813 1791 -22
Lines 69437 68609 -828
Branches 7450 7318 -132
==========================================
+ Hits 45667 45672 +5
+ Misses 21850 21044 -806
+ Partials 1920 1893 -27
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
d04bd8f to
4b1dca2
Compare
4b1dca2 to
d53bc04
Compare
d53bc04 to
cd6b271
Compare
cd6b271 to
eb794a2
Compare
eb794a2 to
37265bd
Compare
Delete hive.py Update hive.py
37265bd to
e9ed8ee
Compare
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
PyHive now contains the fetch_log method which makes the
HiveEngineSpec.fetch_logs()method obsolete—per the comment it mentioned it should be contributed back to PyHive.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION