chore: remove legacy treemap/area#20639
Closed
zhaoyongjie wants to merge 3 commits into
Closed
Conversation
Member
|
@zhaoyongjie are we 100% sure these are unused? If not it seems like a migration would be necessary conditional on the fact that parity exists between the old NVD3 and new ECharts charts. |
4413c68 to
5337aad
Compare
Member
Author
|
@john-bodley thanks for the tip, I updated PR, and the legacy plugins were been kept. when the PR is merged, I will turn this open. |
5337aad to
6cf1c91
Compare
Codecov Report
@@ Coverage Diff @@
## master #20639 +/- ##
=======================================
Coverage 66.79% 66.79%
=======================================
Files 1754 1754
Lines 65874 65862 -12
Branches 7030 7030
=======================================
- Hits 43999 43994 -5
+ Misses 20086 20079 -7
Partials 1789 1789
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Remove unused viz-plugins
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
CI
ADDITIONAL INFORMATION