fix: logger message#20714
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20714 +/- ##
===========================================
- Coverage 66.82% 55.19% -11.64%
===========================================
Files 1750 1750
Lines 65896 65896
Branches 7017 7017
===========================================
- Hits 44035 36370 -7665
- Misses 20075 27740 +7665
Partials 1786 1786
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
john-bodley
approved these changes
Jul 15, 2022
michael-s-molina
approved these changes
Jul 15, 2022
Member
|
@betodealmeida The license error was fixed here so you just need to rebase your PR. |
eschutho
pushed a commit
that referenced
this pull request
Sep 20, 2022
(cherry picked from commit c70d102)
Fahrenheit35
pushed a commit
to Fahrenheit35/superset
that referenced
this pull request
Nov 11, 2022
(cherry picked from commit c70d102)
9 tasks
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Small fix: when we try to load a DB engine spec but it fails (because of missing dependencies, for example) the logging message will also fail because
engine_specis undefined.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION