fix(db): set slices.query_context to MEDIUMTEXT for mysql#20779
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20779 +/- ##
===========================================
- Coverage 66.28% 54.79% -11.49%
===========================================
Files 1756 1756
Lines 66737 66737
Branches 7049 7049
===========================================
- Hits 44238 36571 -7667
- Misses 20702 28369 +7667
Partials 1797 1797
Flags with carried forward coverage won't be shown. Click here to find out more.
|
zhaoyongjie
approved these changes
Jul 20, 2022
9 tasks
9 tasks
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Follow up for #20761, changing
Slice.query_contextandSlice.paramstoMEDIUMTEXTfor MySQL databases. Ideally this should be ran before #20359 and #20346 but that would mean rebasing the existing migrations, which could be problematic for users who already ran both migrations.We'll just accept the risk that some MySQL users may lose
query_contextdata if they didn't manually run this column type change before #20359 and #20346...On Airbnb's Superset instance with about 350k slices, this migration completes in about 50 seconds.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION