fix: add timegrains to data payload#20938
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20938 +/- ##
==========================================
- Coverage 66.38% 66.35% -0.04%
==========================================
Files 1766 1766
Lines 67207 67251 +44
Branches 7129 7129
==========================================
+ Hits 44617 44626 +9
- Misses 20766 20801 +35
Partials 1824 1824
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
lyndsiWilliams
approved these changes
Aug 1, 2022
hughhhh
requested review from
craig-rueda,
dpgaspar and
villebro
as code owners
hughhhh
force-pushed
the
cpq-time-columns
branch
from
ba89735 to
ca9b20e
Compare
Member
|
/testenv up |
Contributor
|
@yousoph Ephemeral environment spinning up at http://54.218.49.113:8080. Credentials are |
Contributor
|
Ephemeral environment shutdown and build artifacts deleted. |
jinghua-qa
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 4, 2022
* add timegrains to data payload * fix * opps * save * integrate type casting for engiines * add perm object * change how wwe raise_for_access * fix orderby on column types * linting (cherry picked from commit 6e5036d)
9 tasks
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
* add timegrains to data payload * fix * opps * save * integrate type casting for engiines * add perm object * change how wwe raise_for_access * fix orderby on column types * linting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Allow users to properly set time filter to update underlying query when chart source = Query
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION