Adding a big number total viz type that is not a timeseries metric by michellethomas · Pull Request #212 · apache/superset

michellethomas · 2016-03-30T00:58:36Z

I'm adding a new big number total viz type that uses the same d3 as the big number but it is not a timeseries metric, so it will aggregate over whatever time period is given (this will allow us to do WAUs). I've also added functionality to add descriptive text below the number. I originally tried to adjust the text size based on the length but couldn't get it to work because of the loading order of the viz.

landscape-bot · 2016-03-30T00:58:43Z

Code quality remained the same when pulling c239f81 on airbnb:big_number_total into d885dd3 on airbnb:master.

landscape-bot · 2016-03-30T01:01:24Z

Code quality remained the same when pulling 2086607 on airbnb:big_number_total into d885dd3 on airbnb:master.

williaster · 2016-03-30T15:59:07Z

@@ -1,4 +1,4 @@
-.big_number g.axis text {
+.big_number g.axis text, .big_number_total g.axis text {


nit, but style-wise (https://github.com/airbnb/css#formatting) each selector should have its own line when using multiple selectors in a rule declaration.

williaster · 2016-03-30T16:15:00Z

a couple of nit picky things about js linting, overall looks good though!

landscape-bot · 2016-04-01T19:16:07Z

Code quality remained the same when pulling 6cfeb0f on airbnb:big_number_total into 9a5a27a on airbnb:master.

coveralls · 2016-04-01T19:24:56Z

Coverage decreased (-0.3%) to 70.863% when pulling 6cfeb0f on big_number_total into 9a5a27a on master.

mistercrunch · 2016-04-03T22:05:47Z

To both showcase this new viz and get unit tests coverage you can add an example slice in caravel/data/__init__.py

mistercrunch · 2016-04-03T22:08:06Z

+    """Put emphasis on a single metric with this big number viz"""
+
+    viz_type = "big_number_total"
+    verbose_name = "Big Number Total"


Maybe this new viz should be just "Big Number" and the previous one should say "Big Number with Trendline" or something. The viz_type we cannot change because of backwards compatibility, but the verbose_name we can change all we want.

mistercrunch · 2016-04-03T22:12:01Z

As a side note it would be nice to have a time expression (much like now) called latest or something like that, that would basically add a WHERE time_column = (SELECT max(time_column) FROM table).

That might be brutal on the database's depending on indexes / partitioning, but maybe there could also be a table level setting called latest_expression or something...

…eries

landscape-bot · 2016-04-07T15:53:21Z

Code quality remained the same when pulling 0dd20b0 on airbnb:big_number_total into bcca840 on airbnb:master.

coveralls · 2016-04-07T16:11:02Z

Coverage decreased (-0.3%) to 71.546% when pulling 0dd20b0 on big_number_total into bcca840 on master.

landscape-bot · 2016-04-07T16:12:54Z

Code quality remained the same when pulling d42279a on airbnb:big_number_total into bcca840 on airbnb:master.

coveralls · 2016-04-07T16:31:47Z

Coverage increased (+0.2%) to 72.041% when pulling d42279a on big_number_total into bcca840 on master.

landscape-bot · 2016-04-07T16:42:03Z

Code quality remained the same when pulling df141cb on airbnb:big_number_total into bcca840 on airbnb:master.

coveralls · 2016-04-07T17:01:53Z

Coverage increased (+0.2%) to 72.041% when pulling df141cb on big_number_total into bcca840 on master.

landscape-bot · 2016-04-07T18:49:11Z

Code quality remained the same when pulling e0eb74f on airbnb:big_number_total into bcca840 on airbnb:master.

michellethomas · 2016-04-07T18:51:47Z

@williaster Thanks for all the feedback. Added fixes. Let me know if there's anything that still doesn't look good

coveralls · 2016-04-07T19:07:01Z

Coverage increased (+0.2%) to 72.041% when pulling e0eb74f on big_number_total into bcca840 on master.

williaster · 2016-04-07T19:52:38Z


-.big_number .domain {
+.big_number .domain,
+.big_number_total .domain{


don't worry about changing it for this diff, but going forward I'm trying to get people to adopt dash case for css eg .big-number-total

BEM is also an interesting approach if you feel like reading :) https://css-tricks.com/bem-101/

williaster · 2016-04-07T19:55:21Z


    viz_type = "big_number"
-    verbose_name = "Big Number"
+    verbose_name = "Big Number with Trendline"


williaster · 2016-04-07T19:59:51Z

LGTM! nice improvement! :)

* init release for wk 45 * update changelog * fix pip dependencies * Update requirements.txt * update requirements * push * Adding docs on bumping submodule / updating roles.yaml * Fixing up requirements.txt * Fixing docs * Minor twweak * Update README.md Co-authored-by: hughhhh <hughmil3s@gmail.com>

…ment (apache#212) Updates the requirements on [@superset-ui/legacy-plugin-chart-sunburst](https://github.com/apache-superset/superset-ui-plugins) to permit the latest version. - [Release notes](https://github.com/apache-superset/superset-ui-plugins/releases) - [Changelog](https://github.com/apache-superset/superset-ui-plugins/blob/master/CHANGELOG.md) - [Commits](apache-superset/superset-ui-plugins@v0.10.0...v0.11.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

williaster reviewed Mar 30, 2016
View reviewed changes

michellethomas force-pushed the big_number_total branch from 2086607 to 6cfeb0f Compare April 1, 2016 19:14

mistercrunch reviewed Apr 3, 2016
View reviewed changes

michellethomas added 3 commits April 7, 2016 08:45

Adding a big number total viz type that is a big number but not times…

794eb36

…eries

Removing the compare options on the big number total

ce54165

Fixing js style formatting

0dd20b0

michellethomas force-pushed the big_number_total branch from 6cfeb0f to 0dd20b0 Compare April 7, 2016 15:52

Adding an example slice for big_number_total

d42279a

Changing the big_number viz verbose names

df141cb

Changing css formatting for big number

e0eb74f

williaster reviewed Apr 7, 2016
View reviewed changes

michellethomas merged commit 59169bf into master Apr 7, 2016

michellethomas deleted the big_number_total branch April 8, 2016 18:15

snyk-bot mentioned this pull request Dec 13, 2021

[Snyk] Upgrade hot-shots from 8.3.1 to 8.5.2 gregnrobinson/superset#6

Open

john-bodley mentioned this pull request Aug 30, 2022

fix(sqllab): table list exceeds MAX_TABLE_NAMES #21262

Closed

9 tasks

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.6 First shipped in 0.8.6 labels Feb 19, 2024

		@@ -1,4 +1,4 @@
		.big_number g.axis text {
		.big_number g.axis text, .big_number_total g.axis text {

Conversation

michellethomas commented Mar 30, 2016

Uh oh!

landscape-bot commented Mar 30, 2016

Uh oh!

landscape-bot commented Mar 30, 2016

Uh oh!

williaster Mar 30, 2016

Choose a reason for hiding this comment

Uh oh!

williaster commented Mar 30, 2016

Uh oh!

landscape-bot commented Apr 1, 2016

Uh oh!

coveralls commented Apr 1, 2016

Uh oh!

mistercrunch commented Apr 3, 2016

Uh oh!

mistercrunch Apr 3, 2016

Choose a reason for hiding this comment

Uh oh!

mistercrunch commented Apr 3, 2016

Uh oh!

landscape-bot commented Apr 7, 2016

Uh oh!

coveralls commented Apr 7, 2016

Uh oh!

landscape-bot commented Apr 7, 2016

Uh oh!

coveralls commented Apr 7, 2016

Uh oh!

landscape-bot commented Apr 7, 2016

Uh oh!

coveralls commented Apr 7, 2016

Uh oh!

landscape-bot commented Apr 7, 2016

Uh oh!

michellethomas commented Apr 7, 2016

Uh oh!

coveralls commented Apr 7, 2016

Uh oh!

williaster Apr 7, 2016

Choose a reason for hiding this comment

Uh oh!

williaster Apr 7, 2016

Choose a reason for hiding this comment

Uh oh!

williaster commented Apr 7, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants