refactor: preparation for time section migration#21766
Merged
zhaoyongjie merged 3 commits intoOct 12, 2022
Merged
Conversation
9 tasks
villebro
approved these changes
Oct 11, 2022
Member
villebro
left a comment
villebro
left a comment
There was a problem hiding this comment.
LGTM with minor constant nit. I hadn't realized how many times we already check for isFeatureEnabled(FeatureFlags.GENERIC_CHART_AXES) 😄
| export const formatTimeRange = (timeRange: string) => { | ||
| export const formatTimeRange = ( | ||
| timeRange: string, | ||
| columnPlaceholder = 'col', |
zhaoyongjie
added a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Oct 12, 2022
9 tasks
zhaoyongjie
added a commit
that referenced
this pull request
Oct 12, 2022
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
In order to easily review the Time Section Migration, all refactoring work is done in this PR. This PR shouldn't change any current behaviors.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION