chore: Convert direct use of antd Icons to use 'Icons' component#21823
Closed
agl-developer wants to merge 11 commits into
Closed
chore: Convert direct use of antd Icons to use 'Icons' component#21823agl-developer wants to merge 11 commits into
agl-developer wants to merge 11 commits into
Conversation
added 3 commits
October 16, 2022 20:17
Change how tests access elements due to reference change
Member
|
@agl-developer please fix CI. I will run an ephemeral env here. Also, it is important that you provide screenshots of before and after. These icons can cause subtle changes in positions and colors which would be hard to notice without a prior reference. |
Codecov Report
@@ Coverage Diff @@
## master #21823 +/- ##
==========================================
+ Coverage 66.95% 66.96% +0.01%
==========================================
Files 1807 1808 +1
Lines 69196 69247 +51
Branches 7402 7410 +8
==========================================
+ Hits 46331 46373 +42
- Misses 20954 20964 +10
+ Partials 1911 1910 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
9 tasks
Member
|
Could a committer close this PR in favor of #22516? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Convert direct use of antd Icons to use 'Icons' component
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
LabeledErrorBountInput Before

LabeledErrorBountInput After

Chart dropdown and select Before

Chart dropdown and select After

Chart Export

Dashboard Filter

TESTING INSTRUCTIONS
ADDITIONAL INFORMATION