fix: Revert shared controls typing change.#22014
Merged
Merged
Conversation
Merged
9 tasks
Codecov Report
@@ Coverage Diff @@
## master #22014 +/- ##
==========================================
+ Coverage 65.72% 65.76% +0.03%
==========================================
Files 1809 1812 +3
Lines 69335 69402 +67
Branches 7413 7448 +35
==========================================
+ Hits 45571 45640 +69
+ Misses 21853 21842 -11
- Partials 1911 1920 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
stephenLYZ
approved these changes
Nov 3, 2022
Member
Author
|
Thanks @stephenLYZ and @zhaoyongjie! |
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
As part of unifying drag-and-drop and non-drag-and-drop controls in #21315, I unnecessarily changed a type to optional. This PR reverts that change and instead updates the viz plugin that was causing TypeScript to complain to match the previous function signature.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION