feat: Enable new dataset creation flow by lyndsiWilliams · Pull Request #22610 · apache/superset

lyndsiWilliams · 2023-01-05T22:20:05Z

SUMMARY

This PR enables the new create dataset flow in dataset view, the + -> Data menu in the app header, chart creation, and database creation. On the create dataset page (/dataset/add/), user is brought to their previous page when the cancel button is clicked and the create chart view when the create dataset button is clicked.

TESTING INSTRUCTIONS

Check all areas in Superset where user can create a dataset, it should bring you to the new create dataset page: /dataset/add
- All creation spots: + Dataset button in dataset view, the + -> Data menu in the app header, chart creation, and database creation.
- There should no longer be an Add Dataset modal in any area of the app
On the new create dataset page, ensure that:
- Cancel button brings you to the previous page you were on
- Create Dataset button brings you to the create chart view with the newly created dataset selected

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codecov · 2023-01-05T22:22:48Z

Codecov Report

Merging #22610 (52e22dc) into master (2de19f1) will increase coverage by 0.25%.
The diff coverage is 43.87%.

❗ Current head 52e22dc differs from pull request most recent head 91c6bb2. Consider uploading reports for the commit 91c6bb2 to get more accurate results

@@            Coverage Diff             @@
##           master   #22610      +/-   ##
==========================================
+ Coverage   67.09%   67.34%   +0.25%     
==========================================
  Files        1869     1875       +6     
  Lines       71605    72086     +481     
  Branches     7821     7854      +33     
==========================================
+ Hits        48043    48547     +504     
+ Misses      21534    21514      -20     
+ Partials     2028     2025       -3

Flag	Coverage Δ
javascript	`53.73% <26.06%> (-0.18%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...gin-chart-echarts/src/Sunburst/EchartsSunburst.tsx	`0.00% <0.00%> (ø)`
...ns/plugin-chart-echarts/src/Sunburst/buildQuery.ts	`0.00% <0.00%> (ø)`
...plugins/plugin-chart-echarts/src/Sunburst/index.ts	`0.00% <0.00%> (ø)`
...lugin-chart-echarts/src/Sunburst/transformProps.ts	`0.00% <0.00%> (ø)`
...gins/plugin-chart-echarts/src/Treemap/constants.ts	`54.54% <ø> (ø)`
.../plugins/plugin-chart-echarts/src/Treemap/types.ts	`100.00% <ø> (ø)`
superset-frontend/src/GlobalStyles.tsx	`0.00% <ø> (ø)`
superset-frontend/src/SqlLab/actions/sqlLab.js	`63.56% <ø> (ø)`
...ols/DndColumnSelectControl/ColumnSelectPopover.tsx	`3.33% <0.00%> (-0.04%)`	⬇️
superset-frontend/src/middleware/asyncEvent.ts	`78.18% <0.00%> (ø)`
... and 51 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

codyml

Thanks, left some comments!

codyml · 2023-01-09T20:04:55Z

One more comment from @yousoph: errors in the new dataset flow should show up as toasts for now; will circle back if that should change for new dataset flow.

codyml

Thanks! Left a few more comments. Redirect to Add Charts and error toasts look great.

…mponents/EmptyState

…nslations, change window.location.href redirect to use history.push()

codyml

One (last, I swear) thing I just noticed is that in the previous modal, saving a dataset would redirect you to /chart/add with a ?dataset=table_name query string, which would autoselect the just-created dataset and also show a toast on the Add Chart page. If this behavior is easy to reproduce it should probably be maintained, but feel free to do it in a separate PR. Database autoselect now works great and everything else LGTM!

lyndsiWilliams · 2023-01-13T00:47:25Z

One (last, I swear) thing I just noticed is that in the previous modal, saving a dataset would redirect you to /chart/add with a ?dataset=table_name query string, which would autoselect the just-created dataset and also show a toast on the Add Chart page. If this behavior is easy to reproduce it should probably be maintained, but feel free to do it in a separate PR. Database autoselect now works great and everything else LGTM!

Easy fix, thanks for that catch! Fixed in this commit.

lyndsiWilliams · 2023-01-13T04:47:54Z

/testenv up

github-actions · 2023-01-13T04:49:51Z

@lyndsiWilliams Ephemeral environment spinning up at http://18.237.97.3:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

lyndsiWilliams · 2023-01-13T21:13:41Z

/testenv up

github-actions · 2023-01-13T21:17:54Z

@lyndsiWilliams Ephemeral environment spinning up at http://35.89.232.0:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

andrey-zayats · 2023-01-17T19:00:09Z

Hi, found an issues, an error occurs when you go to the "create dataset" page after you have deleted the newly connected database, also, the deleted database is displayed in the dropdown list

error.message.mp4

andrey-zayats · 2023-01-17T19:29:36Z

SQL lab page takes forever to load when navigating to it via the top nav bar

SQL.lab.mp4

the same issues when clicking "Create dataset from SQL query" link

andrey-zayats · 2023-01-17T19:50:07Z

Top nav bar disappears in SQL lab (the same in latest master)

andrey-zayats · 2023-01-17T20:45:43Z

after we have created the dataset, it should be marked as "already exists" and the button should be disabled on "create dataset" page, but this does not happen

Repro steps:

Go to "Datasets" -> "+Dataset"
Select examples db, select main schema
Select a database table and click on "create dataset and create chart" button
Select the same database, schema and table
Ensure that dataset is marked as "already exists" and the button is disabled

already.exists.mp4

lyndsiWilliams · 2023-01-17T22:44:35Z

Hi, found an issues, an error occurs when you go to the "create dataset" page after you have deleted the newly connected database, also, the deleted database is displayed in the dropdown list

error.message.mp4

Hey @andrey-zayats , thanks for the review! I've just pushed up fixes for this issue and the "already existing" issue (here). The other issues (slow-loading SQL Lab and disappearing top nav in SQL Lab) are unrelated to my changes.

github-actions · 2023-01-18T02:06:02Z

Ephemeral environment shutdown and build artifacts deleted.

EugeneTorap · 2023-01-18T13:14:16Z

Hi @lyndsiWilliams! Can you move DatasetCreation and DatabaseList to src/pages folder?
#22330 - src/pages structure proposal

lyndsiWilliams · 2023-01-18T20:06:11Z

Hi @lyndsiWilliams! Can you move DatasetCreation and DatabaseList to src/pages folder? #22330 - src/pages structure proposal

Can do! I'll be moving all dataset files to the new structure within the next couple of weeks.

This reverts commit c87f654.

pull-request-size Bot added the size/L label Jan 5, 2023

codyml reviewed Jan 6, 2023

View reviewed changes

codyml mentioned this pull request Jan 9, 2023

feat: add tabs to edit dataset page #22043

Merged

9 tasks

codyml reviewed Jan 11, 2023

View reviewed changes

lyndsiWilliams added 15 commits January 12, 2023 17:06

optimized setDatasets call

72b921f

Remove console.log

8253fe7

Create dataset polish/bug fix

d1f836f

Make defaultPageSize a const and move emptyStateComponent into src/co…

5753b33

…mponents/EmptyState

Change all add dataset entrances to use new create page

834a889

Cancel now redirects to the previous page

89bac92

Create dataset returns user to dataset list

49aff9e

Delete AddDatasetModal

5aedd66

Fix tests

f45d4ea

Use useHistory instead of window.location.href

155236b

Address Cody's review comments

1d355b4

Add dangerToasts to error handling

44fac6e

Fix lint

f1b52e2

Fix useEffect warnings and autosetting db from local storage, add tra…

786bcbf

…nslations, change window.location.href redirect to use history.push()

fix lint

06363d9

lyndsiWilliams force-pushed the lyndsi/enable-dataset-creation branch from a72d058 to 06363d9 Compare January 12, 2023 23:07

pull-request-size Bot added size/XL and removed size/L labels Jan 12, 2023

Add path back into error message

09cc3bf

codyml approved these changes Jan 13, 2023

View reviewed changes

lyndsiWilliams added 2 commits January 12, 2023 18:28

Fix DatabaseModal test by mocking useHistory hook

c69dc5d

Add table_name query to /chart/add/ redirect

5941d03

Change text on footer create button

2255a6c

lyndsiWilliams added 2 commits January 17, 2023 15:57

Add filter by database ID to rison in queryParams

bce77f5

Remove user-selected db from local storage when db is deleted

91c6bb2

lyndsiWilliams merged commit c87f654 into master Jan 18, 2023

lyndsiWilliams deleted the lyndsi/enable-dataset-creation branch January 18, 2023 02:06

villebro added a commit to villebro/superset that referenced this pull request Jan 19, 2023

Revert "feat: Enable new dataset creation flow (apache#22610)"

65724f3

This reverts commit c87f654.

villebro mentioned this pull request Jan 19, 2023

chore(ci): fix numpy type errors and revert #22610 #22782

Merged

9 tasks

villebro added a commit that referenced this pull request Jan 19, 2023

chore(ci): fix numpy type errors and revert #22610 (#22782)

577ac81

lyndsiWilliams restored the lyndsi/enable-dataset-creation branch January 19, 2023 16:26

lyndsiWilliams mentioned this pull request Jan 24, 2023

feat: Enable new dataset creation flow II #22835

Merged

9 tasks

AnushaErrabelli added a commit to preset-io/superset that referenced this pull request Jan 30, 2023

Revert "feat: Enable new dataset creation flow (apache#22610)"

85a2d90

This reverts commit c87f654.

mistercrunch added the 🚢 2.1.3 First shipped in 2.1.3 label Feb 18, 2024

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 First shipped in 2.1.0 and removed 🚢 2.1.3 First shipped in 2.1.3 labels Mar 13, 2024

qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026

feat: Enable new dataset creation flow (apache#22610)

f3829b6

qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026

chore(ci): fix numpy type errors and revert apache#22610 (apache#22782)

4639078

Conversation

lyndsiWilliams commented Jan 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

codecov Bot commented Jan 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codyml left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codyml commented Jan 9, 2023

Uh oh!

codyml left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codyml left a comment

Choose a reason for hiding this comment

Uh oh!

lyndsiWilliams commented Jan 13, 2023

Uh oh!

lyndsiWilliams commented Jan 13, 2023

Uh oh!

github-actions Bot commented Jan 13, 2023

Uh oh!

lyndsiWilliams commented Jan 13, 2023

Uh oh!

github-actions Bot commented Jan 13, 2023

Uh oh!

andrey-zayats commented Jan 17, 2023

Uh oh!

andrey-zayats commented Jan 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrey-zayats commented Jan 17, 2023

Uh oh!

andrey-zayats commented Jan 17, 2023

Uh oh!

lyndsiWilliams commented Jan 17, 2023

Uh oh!

github-actions Bot commented Jan 18, 2023

Uh oh!

EugeneTorap commented Jan 18, 2023

Uh oh!

lyndsiWilliams commented Jan 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lyndsiWilliams commented Jan 5, 2023 •

edited

Loading

codecov Bot commented Jan 5, 2023 •

edited

Loading

andrey-zayats commented Jan 17, 2023 •

edited

Loading