fix: Report screenshot cut off on left and right sides

[lyndsiWilliams]

SUMMARY

This PR fixes report screenshot width. Screenshots were being cut off on the left and right. I fixed this by having the screenshot capture by class standalone and removing the filter bar when standalone=3.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

AFTER:

TESTING INSTRUCTIONS

• Add a report and set the notification method to email
  • Set it to send every minute for quicker testing
• Check your email
• Ensure that the report is properly bordered on the left and right

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #22614 (8b4cd90) into master (db20180) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #22614      +/-   ##
==========================================
+ Coverage   67.00%   67.03%   +0.03%     
==========================================
  Files        1859     1859              
  Lines       71036    71037       +1     
  Branches     7766     7767       +1     
==========================================
+ Hits        47597    47623      +26     
+ Misses      21417    21386      -31     
- Partials     2022     2028       +6     

Flag	Coverage Δ
hive	52.47% <100.00%> (ø)
javascript	53.89% <100.00%> (+0.03%)	⬆️
mysql	78.01% <100.00%> (?)
postgres	78.08% <100.00%> (ø)
presto	52.37% <100.00%> (ø)
python	81.35% <100.00%> (+0.03%)	⬆️
sqlite	76.46% <100.00%> (ø)
unit	51.47% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...d/components/DashboardBuilder/DashboardBuilder.tsx	73.83% <100.00%> (+0.24%)	⬆️
superset/utils/screenshots.py	48.69% <100.00%> (ø)
superset/views/core.py	74.98% <0.00%> (+0.22%)	⬆️
superset/models/core.py	90.47% <0.00%> (+0.64%)	⬆️
superset/db_engine_specs/mysql.py	98.80% <0.00%> (+4.76%)	⬆️
superset/common/utils/dataframe_utils.py	95.23% <0.00%> (+4.76%)	⬆️
...board/components/nativeFilters/FilterBar/index.tsx	58.88% <0.00%> (+8.88%)	⬆️
...rd/components/nativeFilters/FilterBar/keyValue.tsx	40.74% <0.00%> (+22.22%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[eschutho]

/testenv up

[github-actions]

@eschutho Ephemeral environment spinning up at http://54.185.134.130:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.

[villebro]

@lyndsiWilliams I believe this PR has caused a regression for dashboard thumbnails. When rendering dashboard thumbnails, I'm now getting the following timeout error:

Caching dashboard: http://localhost:8088/superset/dashboard/10/
Processing url for thumbnail: b59b6650f84da2dfa80e5c6a10ba69bc
Init selenium driver
Selenium timed out requesting url http://localhost:8088/superset/dashboard/10/
Traceback (most recent call last):
  File "/Users/.../superset/utils/webdriver.py", line 177, in get_screenshot
    element = WebDriverWait(driver, self._screenshot_locate_wait).until(
  File "/Users/.../venv38/lib/python3.8/site-packages/selenium/webdriver/support/wait.py", line 80, in until
    raise TimeoutException(message, screen, stacktrace)
selenium.common.exceptions.TimeoutException: Message:

In this PR we're assuming that dashboards are always being rendered with the standalone flag, but apparently that's only true for alerts & reports. See the logic for dashboard reports (See standalone being set to DashboardStandaloneMode.REPORT.value):

superset/superset/reports/commands/execute.py

Lines 189 to 196 in 3e07de7

	return get_url_path(
	"Superset.dashboard",
	user_friendly=user_friendly,
	dashboard_id_or_slug=self._report_schedule.dashboard_id,
	standalone=DashboardStandaloneMode.REPORT.value,
	force=force,
	**kwargs,
	)

Contrast that with dashboard thumbnails (notice the missing standalone kwarg):

superset/superset/tasks/thumbnails.py

Line 85 in 3e07de7

url = get_url_path("Superset.dashboard", dashboard_id_or_slug=dashboard.id)

It might be a good idea to create a util for generating the chart and dashboard URLs to ensure we're always using the same logic for alerts, reports and thumbs. Thoughts?

[eschutho]

It might be a good idea to create a util for generating the chart and dashboard URLs to ensure we're always using the same logic for alerts, reports and thumbs. Thoughts?

Thanks for catching this error @villebro! I took your suggestion in #23003 and wound up moving the standalone logic closer to the screenshot classes that define the element to capture. I'd love to get your thoughts on that approach.