Skip to content

fix(explore): Fix the test on AnnotationLayer#22876

Closed
justinpark wants to merge 1 commit into
apache:masterfrom
justinpark:fix--explore-annotation-layers-test-failure
Closed

fix(explore): Fix the test on AnnotationLayer#22876
justinpark wants to merge 1 commit into
apache:masterfrom
justinpark:fix--explore-annotation-layers-test-failure

Conversation

@justinpark
Copy link
Copy Markdown
Member

SUMMARY

This commit fixes the test regression due to #22453

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

  • Before
/home/runner/work/superset/superset/superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx:159
  expect(await _testingLibrary.screen.findByText('Chart')).toBeInTheDocument();
  • After

None

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido
Copy link
Copy Markdown
Member

geido commented Jan 26, 2023

Thanks @justinpark a fix was already merged

@justinpark
Copy link
Copy Markdown
Member Author

hotfix already merged

@justinpark justinpark closed this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants