fix: Handles disable Select All on Value Selection#23358
fix: Handles disable Select All on Value Selection#23358sinhashubham95 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Hey @sinhashubham95! Need to update some tests in the Select component since this change is breaking them, for example: do not count unselected disabled options in "Select All"
|
Hi @sinhashubham95. The Enter key acts on the current focused item on the list. I did a quick test here, and if you navigate using the arrow keys to a particular item, press Enter, the item will be selected. If you press Enter again, the item will be deselected. Can you record a video of the behavior you described? |
|
@sinhashubham95 I'm linking a recent fix #23400 that may or may not be related to what you described. |
|
Thanks @michael-s-molina. Let me try it out. I was unavailable this week. Will try to get back today on this. |
|
Closing this PR for now as it seems this issue was resolved. @sinhashubham95 feel free to reopen it in case the issue is still present. |
SUMMARY
Once a value is selected in
Select, theSelect Alloption should be disabled. This is because theSelectsupports theEnterkey, and it is very likely for that to be pressed twice. Once a value is selected usingEnter, andEnteris pressed twice, then instead of 1 value all values(Select All) gets selected.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION