fix(dashboard): show_native_filters leftover#23389
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23389 +/- ##
==========================================
+ Coverage 67.44% 67.58% +0.13%
==========================================
Files 1907 1907
Lines 73493 73537 +44
Branches 7976 7980 +4
==========================================
+ Hits 49571 49702 +131
+ Misses 21873 21787 -86
+ Partials 2049 2048 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eschutho
approved these changes
Mar 17, 2023
Member
|
@betodealmeida alternatively, could we bump the export version and create a new import version? |
jinghua-qa
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 20, 2023
(cherry picked from commit 0222139)
jinghua-qa
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 20, 2023
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
#23228 removed
show_native_filtersfrom dashboards, but it can still be present in exports from older versions. When the key is present, the dashboard is imported correctly, but can't be updated because the schema ofjson_metadatais now invalid.This PR addresses the problem by removing the field on dashboard import. Additionally, for those dashboards that have already been imported with the field, it relaxes the metadata schema to allow updates when
show_native_filtersis present, removing it before processing the metadata.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION