fix(revert): "fix: cache warmup solution non legacy charts. (#23012)"

[john-bodley]

SUMMARY

This reverts #23012 which per #23012 (comment) introduced two known regressions. Granted we could try to roll forward with a formulation which works for both legacy and non-legacy charts, but in the interim I think it's prudent we ensure we don't regress whilst acknowledging the fact that cache warmup for non-legacy charts is still problematic.

cc: @dheeraj-jaiswal-lowes

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #23579 (539367a) into master (9d2f43d) will increase coverage by 0.00%.
The diff coverage is 90.00%.

❗ Current head 539367a differs from pull request most recent head 9fd6c89. Consider uploading reports for the commit 9fd6c89 to get more accurate results

@@           Coverage Diff           @@
##           master   #23579   +/-   ##
=======================================
  Coverage   67.71%   67.72%           
=======================================
  Files        1916     1916           
  Lines       74014    74007    -7     
  Branches     8039     8039           
=======================================
- Hits        50122    50118    -4     
+ Misses      21843    21840    -3     
  Partials     2049     2049           

Flag	Coverage Δ
hive	52.75% <10.00%> (+<0.01%)	⬆️
mysql	78.50% <90.00%> (+<0.01%)	⬆️
postgres	78.58% <90.00%> (+<0.01%)	⬆️
presto	52.68% <10.00%> (+<0.01%)	⬆️
python	82.42% <90.00%> (+<0.01%)	⬆️
sqlite	77.08% <90.00%> (+<0.01%)	⬆️
unit	52.64% <10.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/views/core.py	74.75% <88.88%> (+0.09%)	⬆️
superset/charts/commands/export.py	94.11% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[villebro]

LGTM - I created a filter box, and lo and behold, it indeed has a query context, and based on my quick inspection the payload is invalid (=would return a 400 if sent to the chart data endpoint).

After this revert is merged I can work on a new PR so that

1. saving a legacy chart sets query_context to NULL and fixes existing chart metadata (db migration)
2. reintroduces the functionality from the reverted PR

FYI @dheeraj-jaiswal-lowes

[john-bodley]

Thanks @villebro. Note #23569 was a fix for #23012 which now can't be applied because the execution path in the test has changed after the revert, so if/when you work on a fix it would be good to incorporate said change into it.

[villebro]

Ok thanks for the heads up @john-bodley . I'll make sure to incorporate the work from all prior PRs in my fix 👍