fix(dremio): query with alias#23872
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23872 +/- ##
===========================================
+ Coverage 56.76% 68.11% +11.34%
===========================================
Files 1937 1938 +1
Lines 74929 74973 +44
Branches 8133 8141 +8
===========================================
+ Hits 42534 51068 +8534
+ Misses 30311 21826 -8485
+ Partials 2084 2079 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 314 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eschutho
approved these changes
Apr 28, 2023
jinghua-qa
pushed a commit
to preset-io/superset
that referenced
this pull request
May 1, 2023
(cherry picked from commit 707c626)
2 tasks
9 tasks
OskarNS
added a commit
to OskarNS/superset
that referenced
this pull request
Oct 16, 2023
This reverts commit 707c626.
9 tasks
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
With
GENERIC_CHART_AXESenabled we're producing queries that are invalid for Dremio, eg:This happens because Dremio gets confused by the alias
pickup_dateand the actual columnpickup_date.The solution I found was to turn off projection aliases for Dremio.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
Connect to Dremio and create a "Big number with trendline" chart showing a simple
COUNT(*).ADDITIONAL INFORMATION