Skip to content

fix: handle python_date_format in ExploreMixin#24062

Merged
Antonio-RiveroMartnez merged 1 commit into
masterfrom
sc-70535
May 15, 2023
Merged

fix: handle python_date_format in ExploreMixin#24062
Antonio-RiveroMartnez merged 1 commit into
masterfrom
sc-70535

Conversation

@betodealmeida
Copy link
Copy Markdown
Member

@betodealmeida betodealmeida commented May 15, 2023

SUMMARY

The ExploreMixin class is missing the logic to handle python_date_format, adding it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida requested a review from hughhhh May 15, 2023 18:44
@betodealmeida betodealmeida changed the title fix: handle python_date_format in ExploreMixin fix: handle python_date_format in ExploreMixin May 15, 2023
@betodealmeida betodealmeida requested a review from eschutho May 15, 2023 18:55
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2023

Codecov Report

Merging #24062 (a27d13a) into master (de96372) will increase coverage by 1.76%.
The diff coverage is 45.45%.

❗ Current head a27d13a differs from pull request most recent head 58c0d5a. Consider uploading reports for the commit 58c0d5a to get more accurate results

@@            Coverage Diff             @@
##           master   #24062      +/-   ##
==========================================
+ Coverage   66.46%   68.22%   +1.76%     
==========================================
  Files        1942     1942              
  Lines       75205    75215      +10     
  Branches     8145     8145              
==========================================
+ Hits        49986    51318    +1332     
+ Misses      23134    21812    -1322     
  Partials     2085     2085              
Flag Coverage Δ
hive 53.16% <9.09%> (?)
mysql 78.91% <9.09%> (-0.03%) ⬇️
postgres 78.99% <9.09%> (-0.03%) ⬇️
presto 53.09% <45.45%> (?)
python 82.77% <45.45%> (+3.62%) ⬆️
sqlite 77.51% <9.09%> (-0.03%) ⬇️
unit 53.03% <9.09%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/models/helpers.py 69.11% <45.45%> (-0.10%) ⬇️

... and 91 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Antonio-RiveroMartnez Antonio-RiveroMartnez merged commit 2938c5d into master May 15, 2023
@sadpandajoe
Copy link
Copy Markdown
Member

🏷️ preset:2023.19

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request May 15, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 First shipped in 3.0.0 labels Mar 8, 2024
@mistercrunch mistercrunch deleted the sc-70535 branch March 26, 2024 18:04
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0 First shipped in 3.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants