fix(plugin-chart-echarts): normalize temporal string groupbys#24134
Merged
Conversation
villebro
commented
May 19, 2023
Member
Author
There was a problem hiding this comment.
bycatch: the getLegendProps block was incorrectly nested inside the formatSeriesName block - check with "Hide whitespace" to see the relevant changes.
kgabryje
approved these changes
May 19, 2023
5603c21 to
48b36ee
Compare
Codecov Report
@@ Coverage Diff @@
## master #24134 +/- ##
==========================================
- Coverage 68.27% 68.26% -0.02%
==========================================
Files 1952 1952
Lines 75468 75397 -71
Branches 8202 8204 +2
==========================================
- Hits 51529 51472 -57
+ Misses 21832 21819 -13
+ Partials 2107 2106 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
Removing this PR from 2.1 since normalize non-iso timestamps is is not in 2.1.0 |
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
#23339 introduced the possibility of normalizing non-UTC timestamps so that they produced correctly formatted timestamps. However, the normalizer wasn't being used in the ECharts plugin, causing string based non-timezone timestamps to display incorrectly when used as a groupby.
This adds a call to the
normalizeTimestamputil informatSeriesNameto ensure that string based timestamps are normalized prior to being fed to the timestamp formatter.AFTER
Now the timestamp is formatted correctly:

BEFORE
Previously the timestamp was assumed to be in local timezone, causing the formatted timestamp to be offset by the UTC offset (this was run in UTC+0200):

TESTING INSTRUCTIONS
ADDITIONAL INFORMATION