Skip to content

fix(table): percentage metric should use verbose map#24158

Merged
villebro merged 1 commit into
apache:masterfrom
TechAuditBI:fix/table-percentage-metric-should-use-verbose-map
May 21, 2023
Merged

fix(table): percentage metric should use verbose map#24158
villebro merged 1 commit into
apache:masterfrom
TechAuditBI:fix/table-percentage-metric-should-use-verbose-map

Conversation

@Always-prog
Copy link
Copy Markdown
Contributor

SUMMARY

Percentage metrics don't using verboseMap, this PR fixing it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

Screenshot_52

After

Screenshot_53

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Copy Markdown
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2023

Codecov Report

Merging #24158 (54e1cc3) into master (1583090) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 54e1cc3 differs from pull request most recent head 417b39a. Consider uploading reports for the commit 417b39a to get more accurate results

@@           Coverage Diff           @@
##           master   #24158   +/-   ##
=======================================
  Coverage   68.27%   68.27%           
=======================================
  Files        1952     1952           
  Lines       75367    75369    +2     
  Branches     8208     8210    +2     
=======================================
+ Hits        51455    51457    +2     
  Misses      21806    21806           
  Partials     2106     2106           
Flag Coverage Δ
javascript 54.70% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/plugins/plugin-chart-table/src/transformProps.ts 65.59% <100.00%> (+0.75%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@villebro villebro merged commit febc07a into apache:master May 21, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 First shipped in 3.0.0 labels Mar 8, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0 First shipped in 3.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants