chore(dao): Organize DAOs according to SIP-92#24331
Merged
Merged
Conversation
f821d86 to
3e96de1
Compare
28d5321 to
74cbdbb
Compare
Codecov Report
@@ Coverage Diff @@
## master #24331 +/- ##
==========================================
- Coverage 68.93% 68.91% -0.02%
==========================================
Files 1904 1899 -5
Lines 73878 73842 -36
Branches 8119 8119
==========================================
- Hits 50927 50891 -36
Misses 20840 20840
Partials 2111 2111
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
d72160e to
d330219
Compare
dpgaspar
approved these changes
Jun 16, 2023
Member
dpgaspar
left a comment
There was a problem hiding this comment.
This is great!
"one exception is exceptions" :)
d330219 to
407fa70
Compare
407fa70 to
aafa73c
Compare
This was referenced Jun 20, 2023
This was referenced Jun 20, 2023
9 tasks
9 tasks
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Co-authored-by: JUST.in DO IT <justin.park@airbnb.com>
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
Co-authored-by: JUST.in DO IT <justin.park@airbnb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR is the first of many to related to SIP-92 Proposal for restructuring the Python code base. Specifically it organizes all the DAOs under the
superset/daossubfolder. A few things of note:EmbeddedDAOwas renamedEmbeddedDashboardDAOfor clarity.AnnotationLayerDAOis housed indaos/annotation.pyEmbeddedDashboardDAOandFilterSetDAOare housed indaos/dashboard.pySavedQueryDAOis housed indaos/query.pySSHTunnelDAOis housed indaos/database.pydashboardordashboards. I opted for the former given that:daos(plural) subfolder.dashboard.pyfile contains a collection of DAOs (DashboardDAO,EmbeddedDashboardDAO) we tend to think of the term "dashboard" as a concept/type rather than multiple types.exceptionsas this houses different exception types and is consistent with how other files containing exceptions are named.css_templates/dao.pybecamedaos/css.pyrow_level_security/dao.pybecamedaos/security.pyBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION