fix(dashboard): native filters do not preserve bigint

[justinpark]

SUMMARY

There is an overflow issue when searching for bigint records in the native filters, i.e., the value passed to the backend is a rounded form of the specified UI value.
This hotfix handles the bigint value in a string form to preserve the value in JSON

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:

Before:

TESTING INSTRUCTIONS

• Specs
• Go to dashboard and add a number field in a native filter
• type any big number and check the request payload

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[john-bodley]

@justinpark do you know what additional value using Number(...) provides? This is how the backend handles the filtering logic which casts strings to numbers and thus maybe it's ok for the backend to handle both cases, i.e., we could remove lines 54–60.

We could include a comment of the form,

// for numeric columns the backend casts the search string to the appropriate type—preventing JavaScript overflow. Additionally we use the fairly crude(and insufficient)  >= operator as a proxy for detecting whether the search string is contained within the column given there is no trivial way of dynamically casting the the column type.

[codecov]

Codecov Report

Merging #24413 (4e0b3eb) into master (892de8a) will decrease coverage by 0.05%.
The diff coverage is 85.71%.

❗ Current head 4e0b3eb differs from pull request most recent head 260d421. Consider uploading reports for the commit 260d421 to get more accurate results

@@            Coverage Diff             @@
##           master   #24413      +/-   ##
==========================================
- Coverage   68.96%   68.91%   -0.05%     
==========================================
  Files        1904     1904              
  Lines       74092    73922     -170     
  Branches     8120     8120              
==========================================
- Hits        51100    50946     -154     
+ Misses      20880    20865      -15     
+ Partials     2112     2111       -1     

Flag	Coverage Δ
javascript	55.65% <73.68%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ackages/superset-ui-core/src/utils/featureFlags.ts	100.00% <ø> (ø)
superset-frontend/src/SqlLab/fixtures.ts	100.00% <ø> (ø)
superset-frontend/src/pages/DatasetList/index.tsx	57.76% <ø> (ø)
...rset-frontend/src/profile/components/Favorites.tsx	80.00% <ø> (ø)
superset/charts/api.py	87.07% <ø> (ø)
superset/config.py	91.97% <ø> (ø)
superset/connectors/sqla/models.py	90.37% <ø> (-0.07%)	⬇️
superset/dashboards/api.py	92.58% <ø> (ø)
superset/dashboards/schemas.py	99.02% <ø> (-0.01%)	⬇️
superset/datasets/api.py	87.95% <ø> (ø)
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[john-bodley]

#24418 is an alternative formulation which also addresses searching/filtering of numerical values.