chore: bump prophet and holidays (predictive forecasting)#24426
chore: bump prophet and holidays (predictive forecasting)#24426sebastianliebscher wants to merge 1 commit into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24426 +/- ##
=======================================
Coverage 68.91% 68.91%
=======================================
Files 1904 1904
Lines 73920 73920
Branches 8119 8119
=======================================
Hits 50944 50944
Misses 20865 20865
Partials 2111 2111
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Nice one @sebastianliebscher ! ❤️ FYI, @john-bodley has a related PR in the works, but maybe we can get this merged first and then fast follow John's PR to get those tests etc cleaned up. |
|
@sebastianliebscher thanks for the PR. Personally I would prefer #24129 as it reenables the tests which highlighted a few issues with the way There's a CI issue I still need to look into, i.e., for some reason the test fails on MySQL but works for SQLite and Postgres. |
|
Oh, didn't see your PR which will handle the bump + fixing the tests. Closed in favor of #24129 |
SUMMARY
This PR bumps optional dependency
prophetfor the predictive forecasting feature. Prophet made huge performance gains in the last releases https://github.com/facebook/prophet/releases and dropped some dependencies.Also bumped
holidaysas needed for prophet. https://github.com/dr-prodigy/python-holidays/releasesNote: Although prophet worked before and after the bump, their related integration tests still fail #24406. So this PR may be blocked by this issue.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
pip install -e '.[prophet]'ADDITIONAL INFORMATION