fix(native-filters): Infinite load when filter with default first value is out of scope in horizontal bar#24542
Merged
Conversation
…ue is out of scope in horizontal bar
villebro
approved these changes
Jun 28, 2023
geido
approved these changes
Jun 28, 2023
Codecov Report
@@ Coverage Diff @@
## master #24542 +/- ##
=======================================
Coverage 58.22% 58.22%
=======================================
Files 1903 1904 +1
Lines 74026 74027 +1
Branches 8118 8118
=======================================
+ Hits 43100 43101 +1
Misses 28815 28815
Partials 2111 2111
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
…ue is out of scope in horizontal bar (apache#24542)
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
…ue is out of scope in horizontal bar (apache#24542)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
When user added a native filter with "Select first filter value by default" checked and set a scope to a PR that's initially out of scope, the dashboard won't load if the native filters bar is in horizontal mode.
This PR fixes it by setting
forceRenderon the dropdown content in horizontal bar if there is a filter with the option selected.A similar error has been fixed in PR #23299 - however, it turned out that the fix worked only for filter bar in vertical mode.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screen.Recording.2023-06-28.at.13.43.24.mov
After:
Screen.Recording.2023-06-28.at.13.42.36.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION