chore: Remove obsolete legacy visualizations

[john-bodley]

SUMMARY

Whilst working on #24671 I realize that some non-legacy charts (which are invoked via the /api/v1/chart RESTful API endpoint) are still present in superset.viz meaning the logic outlined in said PR for differentiating between legacy and non-legacy charts was incorrect.

This PR removes the following charts (which were marked as deprecated in 3.0 though in actuality were obsolete):

• TableViz
• BigNumberViz
• BigNumberTotalViz

which will ensure that the logic in #24671 will be correct.

Technically (as illustrated by the augmented tests) these visualization types could be invoked either using the legacy or non-legacy RESTful API endpoint, though in actuality (per the frontend logic) they would only ever be invoked under the later.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

I systematically went through all the visualization types in superset/viz.py (all NVD3 and DeckGL charts were bucketed together) and inspected which RESTful API endpoint was being invoked, i.e., any chart using the RESTful /superset/explore_json endpoint (or similar) remained.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #24675 (4ebe559) into master (a156816) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head 4ebe559 differs from pull request most recent head ac7761a. Consider uploading reports for the commit ac7761a to get more accurate results

@@            Coverage Diff             @@
##           master   #24675      +/-   ##
==========================================
- Coverage   68.97%   68.91%   -0.07%     
==========================================
  Files        1902     1902              
  Lines       74007    73909      -98     
  Branches     8186     8186              
==========================================
- Hits        51047    50931     -116     
- Misses      20839    20857      +18     
  Partials     2121     2121              

Flag	Coverage Δ
hive	54.18% <ø> (+0.05%)	⬆️
mysql	79.24% <ø> (-0.11%)	⬇️
postgres	79.33% <ø> (-0.12%)	⬇️
presto	54.08% <ø> (+0.05%)	⬆️
python	83.35% <ø> (-0.10%)	⬇️
sqlite	77.91% <ø> (-0.12%)	⬇️
unit	54.89% <ø> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/viz.py	64.51% <ø> (-2.39%)	⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[john-bodley]

Switching out for a legacy chart which invokes the /superset/explore_json RESTful API endpoint.

[john-bodley]

Currently caching only works with legacy charts and removal of the TableViz now treats the Girls chart as a non-legacy chart. One could argue this is a regression—in terms of fewer charts being eligible for caching—but the problem will be rectified in #24671.

[john-bodley]

See previous comment.

[john-bodley]

See previous comment.

[john-bodley]

See previous comment.

[john-bodley]

Any legacy viz type works.

[john-bodley]

Any legacy viz type should work.

[michael-s-molina]

LGTM. Thanks for the cleanup.

[john-bodley]

Closing in favor of #24692.