feat: migrate charts on import

[betodealmeida]

SUMMARY

When importing a chart, migrate it to a new visualization type if possible.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

A legacy area chart:

When exported and imported into Superset running this branch we get a new echarts area chart:

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #24703 (f8c3bba) into master (65fb8e1) will decrease coverage by 0.03%.
The diff coverage is 78.17%.

❗ Current head f8c3bba differs from pull request most recent head 83bb63f. Consider uploading reports for the commit 83bb63f to get more accurate results

@@            Coverage Diff             @@
##           master   #24703      +/-   ##
==========================================
- Coverage   68.97%   68.95%   -0.03%     
==========================================
  Files        1901     1902       +1     
  Lines       74006    73929      -77     
  Branches     8182     8175       -7     
==========================================
- Hits        51045    50975      -70     
- Misses      20840    20841       +1     
+ Partials     2121     2113       -8     

Flag	Coverage Δ
hive	54.14% <39.07%> (+0.01%)	⬆️
mysql	79.17% <64.90%> (-0.19%)	⬇️
postgres	79.27% <68.21%> (-0.18%)	⬇️
presto	54.03% <39.07%> (+0.01%)	⬆️
python	83.33% <78.14%> (-0.12%)	⬇️
sqlite	77.84% <64.90%> (-0.19%)	⬇️
unit	54.96% <57.61%> (+0.12%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...src/components/ColumnTypeLabel/ColumnTypeLabel.tsx	100.00% <ø> (ø)
...d/packages/superset-ui-chart-controls/src/index.ts	100.00% <ø> (ø)
...-chart-controls/src/sections/advancedAnalytics.tsx	14.28% <ø> (ø)
...rset-ui-chart-controls/src/sections/chartTitle.tsx	100.00% <ø> (ø)
...legacy-plugin-chart-partition/src/controlPanel.tsx	25.00% <ø> (ø)
...gins/legacy-plugin-chart-rose/src/controlPanel.tsx	50.00% <ø> (ø)
...gins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx	100.00% <ø> (ø)
.../BigNumber/BigNumberWithTrendline/controlPanel.tsx	16.66% <ø> (ø)
...s/plugin-chart-echarts/src/Funnel/controlPanel.tsx	66.66% <ø> (ø)
...ns/plugin-chart-echarts/src/Gauge/controlPanel.tsx	66.66% <ø> (ø)
... and 45 more

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[betodealmeida]

Ping @michael-s-molina, care to take another look? 🙇🏼

[michael-s-molina]

It's only the Area migration that is incomplete. I don't think it's a good idea to create this enum because we don't want to allow incomplete or not implemented migrations. Can we assume that all new migrations should be complete and just skip area for now when importing?

[betodealmeida]

Sure, I just worried that in the future someone's going to fix the area migration but will not change the import logic. I'll leave a comment in the area migrator.

[michael-s-molina]

@betodealmeida I'm already working on the Area migration in #23870. Adding a comment to the code sounds great!

[michael-s-molina]

LGTM. Thank you for the PR @betodealmeida and for addressing all comments!