chore: Add explicit ON DELETE CASCADE for embedded_dashboards#24939
Merged
michael-s-molina merged 3 commits intoAug 10, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24939 +/- ##
==========================================
- Coverage 69.00% 69.00% -0.01%
==========================================
Files 1906 1906
Lines 74144 74141 -3
Branches 8211 8211
==========================================
- Hits 51164 51161 -3
Misses 20856 20856
Partials 2124 2124
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
john-bodley
force-pushed
the
john-bodley--embedded-dashboards-ondelete-cascade
branch
from
934f628 to
cd27612
Compare
9 tasks
michael-s-molina
approved these changes
Aug 10, 2023
Member
michael-s-molina
left a comment
michael-s-molina
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the improvement @john-bodley!
michael-s-molina
added
the
v3.0
michael-s-molina
added a commit
that referenced
this pull request
Aug 10, 2023
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
9 tasks
mistercrunch
added
🍒 3.0.0
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
…#24939) Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
…#24939) Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Somewhat akin to #24628, this PR ensures explicit ON DELETE CASCADE operations are set for the
embedded_dashboardstable which means these relationships don't need to be explicitly deleted for non-SQLAlchemy ORM operations.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION