Skip to content

Conversation

@mdeshmu
Copy link
Contributor

@mdeshmu mdeshmu commented Aug 19, 2023

SUMMARY

PyHive added support for Python 3.11 and SQLAlchemy 2.0 recently.

pure-sasl library is installed in all PY versions since it is a dependency of thrift-sasl, a dependency of PyHive.

PY < 3.11: sasl library will be installed and used as PyHive's code gives it first preference.
PY >= 3.11 Only pure-sasl library will be installed and used.

test-postgres-hive CI test in this repo will always pure-sasl because PY 11 test cases fail if sasl is installed.

Note: 'pyhive[hive]' extras uses sasl that doesn't support Python 3.11, See cloudera/python-sasl#30. Hence PyHive also supports pure-sasl via additional extras 'pyhive[hive_pure_sasl]' which support Python 3.11 along with all previous Python versions.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

PY 3.11: https://github.com/apache/superset/actions/runs/5945658123/job/16125068727?pr=25030
PY 3.10: https://github.com/apache/superset/actions/runs/5945651721/job/16125052276?pr=25030
PY 3.9: https://github.com/apache/superset/actions/runs/5945685670/job/16125136349?pr=25030

cc: @EugeneTorap @bkyryliuk

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@mdeshmu mdeshmu changed the title Bump PyHive build(deps): Bump PyHive Aug 19, 2023
@john-bodley john-bodley requested a review from bkyryliuk August 21, 2023 16:48
@mdeshmu mdeshmu force-pushed the bump-pyhive branch 3 times, most recently from b6ece7b to 7631b28 Compare August 23, 2023 01:44
@bkyryliuk
Copy link
Member

LG%fix precommit

@mdeshmu
Copy link
Contributor Author

mdeshmu commented Aug 24, 2023

LG%fix precommit

rebased with master and pre-commit got fixed

@bkyryliuk bkyryliuk merged commit 8d33400 into apache:master Aug 24, 2023
@mdeshmu mdeshmu deleted the bump-pyhive branch October 1, 2023 10:35
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 First shipped in 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.1.0 First shipped in 3.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants