Skip to content

chore: Remove the ability to switch to filter-box chart when DASHBOARD_NATIVE_FILTERS feature is enabled#25275

Merged
michael-s-molina merged 1 commit into
apache:masterfrom
john-bodley:john-bodley--fix-23142
Sep 12, 2023
Merged

chore: Remove the ability to switch to filter-box chart when DASHBOARD_NATIVE_FILTERS feature is enabled#25275
michael-s-molina merged 1 commit into
apache:masterfrom
john-bodley:john-bodley--fix-23142

Conversation

@john-bodley
Copy link
Copy Markdown
Member

@john-bodley john-bodley commented Sep 12, 2023

SUMMARY

This PR is a follow up to #23142. Previously I removed the ability to add a filter-box chart when the DASHBOARD_NATIVE_FILTERS feature was enabled, but neglected to take into account switching visualization types.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

Screenshot 2023-09-12 at 11 11 49 AM

AFTER

Screenshot 2023-09-12 at 10 57 24 AM

TESTING INSTRUCTIONS

Manual testing.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley marked this pull request as ready for review September 12, 2023 18:12
Copy link
Copy Markdown
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-bodley john-bodley added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Sep 12, 2023
Comment thread superset-frontend/src/explore/components/controls/VizTypeControl/index.tsx Outdated
@john-bodley john-bodley force-pushed the john-bodley--fix-23142 branch from be3c0d3 to 329ff44 Compare September 12, 2023 20:06
@michael-s-molina michael-s-molina merged commit 8eff5a7 into apache:master Sep 12, 2023
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Sep 12, 2023
…D_NATIVE_FILTERS feature is enabled (apache#25275)

(cherry picked from commit 8eff5a7)
michael-s-molina pushed a commit that referenced this pull request Sep 13, 2023
…D_NATIVE_FILTERS feature is enabled (#25275)

(cherry picked from commit 8eff5a7)
john-bodley added a commit to john-bodley/superset that referenced this pull request Sep 13, 2023
…D_NATIVE_FILTERS feature is enabled (apache#25275)

(cherry picked from commit 8eff5a7)
eschutho pushed a commit to Superset-Community-Partners/superset that referenced this pull request Sep 21, 2023
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🍒 3.0.0 Cherry-picked to 3.0.0 🍒 3.0.1 Cherry-picked to 3.0.1 🍒 3.0.2 Cherry-picked to 3.0.2 🍒 3.0.3 Cherry-picked to 3.0.3 🍒 3.0.4 Cherry-picked to 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 First shipped in 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 Cherry-picked to 3.0.0 🍒 3.0.1 Cherry-picked to 3.0.1 🍒 3.0.2 Cherry-picked to 3.0.2 🍒 3.0.3 Cherry-picked to 3.0.3 🍒 3.0.4 Cherry-picked to 3.0.4 🚢 3.1.0 First shipped in 3.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants