feat: Add Bubble chart migration logic#26033
Merged
michael-s-molina merged 2 commits intoNov 21, 2023
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #26033 +/- ##
==========================================
+ Coverage 69.05% 69.08% +0.03%
==========================================
Files 1938 1941 +3
Lines 75837 75896 +59
Branches 8427 8444 +17
==========================================
+ Hits 52367 52434 +67
+ Misses 21300 21286 -14
- Partials 2170 2176 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
michael-s-molina
changed the title
john-bodley
reviewed
Nov 21, 2023
| source_viz_type = "bubble" | ||
| target_viz_type = "bubble_v2" | ||
| rename_keys = { | ||
| "bottom_margin": "x_axis_title_margin", |
Member
There was a problem hiding this comment.
Unrelated, but what's the reason we have a mix of snake- and camel-case in the chart properties?
Member
Author
There was a problem hiding this comment.
It's always the same answer... 😏
| self.data["x_ticks_layout"] = 45 if x_ticks_layout == "45°" else 0 | ||
|
|
||
| # Truncate Y-axis by default to preserve layout | ||
| self.data["y_axis_showminmax"] = True |
Member
There was a problem hiding this comment.
Just to confirm, this occurs prior to the renaming of the keys?
| if self.data.get("x_axis_label") and ( | ||
| not bottom_margin or bottom_margin == "auto" | ||
| ): | ||
| self.data["bottom_margin"] = 30 |
Member
There was a problem hiding this comment.
Any reason the bottom margin is now fix to 30 (pixels?) as opposed to being automatic?
Member
Author
There was a problem hiding this comment.
Layout adjustments to match the legacy version's look.
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
josedev-union
pushed a commit
to Ortege-xyz/studio
that referenced
this pull request
Jan 22, 2024
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
mistercrunch
added
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds the Bubble chart migration logic (NVD3 ➡️ ECharts). Users can execute this migration using the #25304 CLI command and disable the legacy version with the VIZ_TYPE_DENYLIST configuration.
@sadpandajoe @jinghua-qa
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
1 - Upgrade a Bubble chart using the CLI command
2 - Check the new chart
3 - Downgrade a Bubble chart using the CLI command
4 - Check the legacy chart
ADDITIONAL INFORMATION