Skip to content

Csv download improvements#265

Merged
mistercrunch merged 4 commits into
apache:masterfrom
andrewhn:csv_download_improvements
Apr 6, 2016
Merged

Csv download improvements#265
mistercrunch merged 4 commits into
apache:masterfrom
andrewhn:csv_download_improvements

Conversation

@andrewhn
Copy link
Copy Markdown
Contributor

@andrewhn andrewhn commented Apr 5, 2016

Hi,

This PR does two things:

  • names csv and json files (with extension) via a Content-Disposition header
  • includes a header in CSV output where data is meaningful (i.e. index is not generic). Currently, for example, time series data is outputted without timestamps and pivot table data is exported without row names

@landscape-bot
Copy link
Copy Markdown

Code Health
Code quality remained the same when pulling 1c840f7 on andrewhn:csv_download_improvements into 81de51b on airbnb:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.03%) to 71.338% when pulling 1c840f7 on andrewhn:csv_download_improvements into 81de51b on airbnb:master.

@landscape-bot
Copy link
Copy Markdown

Code Health
Code quality remained the same when pulling f6afaa3 on andrewhn:csv_download_improvements into 3175882 on airbnb:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.03%) to 71.302% when pulling f6afaa3 on andrewhn:csv_download_improvements into 3175882 on airbnb:master.

@landscape-bot
Copy link
Copy Markdown

Code Health
Code quality remained the same when pulling d049199 on andrewhn:csv_download_improvements into c2baa53 on airbnb:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.03%) to 71.302% when pulling d049199 on andrewhn:csv_download_improvements into c2baa53 on airbnb:master.

@mistercrunch
Copy link
Copy Markdown
Member

LGTM, thanks for the PR

@mistercrunch mistercrunch merged commit 65e72d0 into apache:master Apr 6, 2016
isaac-jaynes-imperva added a commit to isaac-jaynes-imperva/superset that referenced this pull request Jan 7, 2026
* SONK-3456: Fixed report sending IP

* SONK-3456: Added back email IP config

* SONK-3456: Fixed report sending IP

* SONK-3456: Lint fixes

* SONK-3456: Fix import

* SONK-3456: Fix import

* SONK-3456: Lint fix

* SO-132: Remove IP address from config

* SO-132: Fix syntax error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants