Skip to content

Optimizing the standalone view #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mistercrunch merged 1 commit into from
Apr 24, 2017
Merged

Optimizing the standalone view #2663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions superset/assets/javascripts/explorev2/components/ExploreViewContainer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,11 @@ class ExploreViewContainer extends React.Component {
}

componentDidMount() {
this.props.actions.fetchDatasources();
if (!this.props.standalone) {
this.props.actions.fetchDatasources();
}
window.addEventListener('resize', this.handleResize.bind(this));
this.triggerQueryIfNeeded();
}

componentWillReceiveProps(np) {
Expand All @@ -47,9 +50,7 @@ class ExploreViewContainer extends React.Component {
}

componentDidUpdate() {
if (this.props.triggerQuery && !this.hasErrors()) {
this.runQuery();
}
this.triggerQueryIfNeeded();
}

componentWillUnmount() {
Expand All @@ -61,7 +62,8 @@ class ExploreViewContainer extends React.Component {
this.props.actions.removeControlPanelAlert();
this.props.actions.removeChartAlert();

this.runQuery();
this.props.actions.triggerQuery();
Copy link
Copy Markdown

@ascott ascott Apr 22, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious, why do we triggerQuery before unmount?

Copy link
Copy Markdown
Member Author

@mistercrunch mistercrunch Apr 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on this is onQuery, it just looks like it's componentWillUnmount because of the way Github folded the code...


history.pushState(
{},
document.title,
Expand All @@ -81,8 +83,10 @@ class ExploreViewContainer extends React.Component {
}


runQuery() {
this.props.actions.runQuery(this.props.form_data);
triggerQueryIfNeeded() {
if (this.props.triggerQuery && !this.hasErrors()) {
this.props.actions.runQuery(this.props.form_data);
}
}

handleResize() {
Expand Down