chore: Migrate AlteredSliceTag to typescript#27030
Merged
geido merged 14 commits intoFeb 13, 2024
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
geido
reviewed
Feb 6, 2024
…github.com/EnxDev/superset into chore/typescript-migration-AlteredSliceTag
geido
reviewed
Feb 8, 2024
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27030 +/- ##
==========================================
- Coverage 67.31% 67.14% -0.17%
==========================================
Files 1895 1900 +5
Lines 74202 74397 +195
Branches 8219 8293 +74
==========================================
+ Hits 49949 49957 +8
- Misses 22204 22385 +181
- Partials 2049 2055 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
geido
reviewed
Feb 9, 2024
Member
geido
left a comment
geido
left a comment
There was a problem hiding this comment.
Looks good. Just a few final touches. I saw that you did not migrate the test file, however, I think that is the right choice considering that test should be converted to RTL and likely to rewritten.
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
…github.com/EnxDev/superset into chore/typescript-migration-AlteredSliceTag
Member
|
/testenv up |
Contributor
|
@geido Ephemeral environment spinning up at http://34.219.235.255:8080. Credentials are |
geido
approved these changes
Feb 13, 2024
Contributor
|
Ephemeral environment shutdown and build artifacts deleted. |
9 tasks
mistercrunch
added
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Co-authored-by: geido <diegopucci.me@gmail.com> Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
Co-authored-by: geido <diegopucci.me@gmail.com> Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Migrate AlteredSliceTag to typescript
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION