fix: removes old deprecated sqllab endpoints#27117
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27117 +/- ##
==========================================
+ Coverage 67.16% 69.49% +2.32%
==========================================
Files 1900 1901 +1
Lines 74447 74432 -15
Branches 8297 8300 +3
==========================================
+ Hits 50005 51723 +1718
+ Misses 22387 20655 -1732
+ Partials 2055 2054 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
@dpgaspar Could you also add a note to @justinpark Will this impact our users in anyway? |
john-bodley
approved these changes
Feb 14, 2024
Member
john-bodley
left a comment
john-bodley
left a comment
There was a problem hiding this comment.
LGTM. This is a breaking change, but we're still in a breaking change window.
john-bodley
added
the
review:checkpoint
dpgaspar
requested review from
betodealmeida,
eschutho,
geido,
jinghua-qa and
rusackas
as code owners
dpgaspar
changed the title
michael-s-molina
approved these changes
Feb 15, 2024
Member
michael-s-molina
left a comment
michael-s-molina
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the cleanup @dpgaspar!
geido
approved these changes
Feb 15, 2024
john-bodley
removed
the
review:checkpoint
grvoicu
added a commit
to grvoicu/superset
that referenced
this pull request
Feb 20, 2024
…-to-the-embedded-dashboard * master: (1182 commits) fix(ci): mypy pre-commit issues (apache#27161) feat(Alerts and Reports): Modal redesign (apache#26202) refactor: Migrate ErrorBoundary to typescript (apache#27143) chore(tests): Remove unnecessary explicit Flask-SQLAlchemy session expunges (apache#27136) fix(plugins): Apply dashboard filters to comparison query in BigNumber with Time Comparison chart (apache#27138) fix: Duplicated toast messages (apache#27135) docs: add Geotab to users list (apache#27134) fix: Plain error message when visiting a dashboard via permalink without permissions (apache#27132) fix: ID param for DELETE ssh_tunnel endpoint (apache#27130) chore(hail mary): Update package-lock.json via npm-audit-fix (apache#26693) chore: lower cryptography min version to 41.0.2 (apache#27129) docs(miscellaneous): Export Datasoruces: export datasources exports to ZIP (apache#27120) fix(pivot-table-v2): Added forgotten translation pivot table v2 (apache#22840) fix: RLS modal overflow (apache#27128) refactor: Updates some database columns to MediumText (apache#27119) fix: gevent upgrade to 23.9.1 (apache#27112) fix: removes old deprecated sqllab endpoints (apache#27117) feat(storybook): Co-habitating/Upgrading Storybooks to v7 (dependency madness ensues) (apache#26907) fix: bump grpcio, urllib3 and paramiko (apache#27124) chore(internet_port): added new ports and removed unnecessary string class (apache#27078) ...
michael-s-molina
added
the
risk:breaking-change
3 tasks
9 tasks
mistercrunch
added
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Removes and old deprecated endpoint
/superset/sqllab. Also removes a false positive security issue identified by CodeQLBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION