Skip to content

chore: add annotations to sql_parse.py#27520

Merged
betodealmeida merged 1 commit into
masterfrom
sqlparse-annotations
Mar 14, 2024
Merged

chore: add annotations to sql_parse.py#27520
betodealmeida merged 1 commit into
masterfrom
sqlparse-annotations

Conversation

@betodealmeida
Copy link
Copy Markdown
Member

SUMMARY

Adding to sql_parse.py:

from __future__ import annotations

It will help review the next PR for #26786.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida marked this pull request as ready for review March 14, 2024 21:30
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.69%. Comparing base (2fdf6d7) to head (e8bec0a).
Report is 1421 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27520      +/-   ##
==========================================
+ Coverage   67.39%   69.69%   +2.30%     
==========================================
  Files        1909     1909              
  Lines       74736    74740       +4     
  Branches     8326     8326              
==========================================
+ Hits        50368    52093    +1725     
+ Misses      22318    20597    -1721     
  Partials     2050     2050              
Flag Coverage Δ
mysql 78.00% <86.66%> (-0.01%) ⬇️
postgres 78.14% <86.66%> (-0.01%) ⬇️
presto 53.69% <80.00%> (?)
python 83.06% <100.00%> (+4.77%) ⬆️
sqlite 77.57% <86.66%> (-0.01%) ⬇️
unit 56.68% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@betodealmeida
Copy link
Copy Markdown
Member Author

I'm also working on fixing that Hive test, in a separate PR.

@betodealmeida betodealmeida merged commit 024b88a into master Mar 14, 2024
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
@rusackas rusackas deleted the sqlparse-annotations branch April 16, 2024 16:52
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 First shipped in 4.1.0 labels Nov 27, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 4.1.0 First shipped in 4.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants