fix(explore): hide advanced analytics for non temporal xaxis

[justinpark]

SUMMARY

The superset feature allows users to choose a non-temporal column for the x-axis.
However, when a non-temporal column is selected, advanced analytics and forecast options are not compatible.

In order to address this, UI should dynamically hide these features when a non-temporal column is selected.
This commit introduces the visibility option in the ControlPanelSectionConfig, enabling the hiding of specific groups of controlSets.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

before--hide-non-temporal.mov

After:

after--hide-non-temporal.mov

TESTING INSTRUCTIONS

Choose non-temporal column in x-axis option
Verify that "Advanced analytics" and "Predictive Analytics" sections are hidden

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[michael-s-molina]

Thank you for the PR @justinpark. I left some first-pass comments.

[michael-s-molina]

Can we rename this to showTimeRelatedControls?

[justinpark]

@michael-s-molina to clarify and specify the functionality, i'm thinking of use displayWhenTimeRelatedControls.
What do you think?

[michael-s-molina]

displayTimeRelatedControls (without when) works too.

[michael-s-molina]

Can you avoid describe?

[michael-s-molina]

Suggested change

	description: t('Advanced analytical post processin'),
	description: t('Advanced analytics post processing'),

[michael-s-molina]

You're also testing if the panel is displayed when the visibility is true.

Suggested change

	test('hide ControlPanelSections when its visibility is false', async () => {
	test('visibility of panels is correctly applied', async () => {

[michael-s-molina]

@justinpark Can you also make sure to ignore or remove the values from the form data in case a user starts with a temporal column, fills the advanced properties and later changes to a categorial x-axis?

[justinpark]

@justinpark Can you also make sure to ignore or remove the values from the form data in case a user starts with a temporal column, fills the advanced properties and later changes to a categorial x-axis?

Done

[Vovch]

A bit too late, but I guess there should be omit(hiddenFormData, fieldNames), otherwise it seems to break any field that was hidden once.

[justinpark]

@Vovch thanks for catching up. I'll post the hotfix which will fix the #29331

[sfirke]

@Vovch are you saying this introduced a bug? Based on your comment I am trying this out in 4.0.2rc1 and indeed experiencing something that might be a bug. I created a new issue #29331 for it and would appreciate if you can expand on whether this is what you were talking about.