fix: Update migration logic in #27119#28482
Merged
john-bodley merged 2 commits intoMay 20, 2024
Merged
Conversation
9 tasks
john-bodley
added
the
risk:may-require-downtime
john-bodley
force-pushed
the
john-bodley--migration-longtext
branch
from
8a8a210 to
2cc5ee3
Compare
john-bodley
force-pushed
the
john-bodley--migration-longtext
branch
from
2cc5ee3 to
d72f46c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #28482 +/- ##
===========================================
+ Coverage 60.48% 83.48% +22.99%
===========================================
Files 1931 521 -1410
Lines 76236 37484 -38752
Branches 8568 0 -8568
===========================================
- Hits 46114 31294 -14820
+ Misses 28017 6190 -21827
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
michael-s-molina
approved these changes
May 16, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR is a follow up #28422 (which needs to be cherry-picked to remedy an issue, but can't include a migration). Specifically it also adds a new migration to resize specific columns back to
LONGTEXTif the previous migration has already been run. If not, the migration is a no-op.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION