chore(docs): remove mention of MariaDB in dev environment setup#29790
Merged
Conversation
rusackas
approved these changes
Jul 31, 2024
Member
|
Oops... my little documentation link checker is finding issues. I'll push a commit here to (hopefully) resolve that. |
rusackas
requested review from
betodealmeida,
craig-rueda,
dpgaspar,
eschutho,
geido,
john-bodley,
kgabryje,
mistercrunch,
nytai and
villebro
as code owners
github-actions
Bot
added
the
github_actions
rusackas
changed the title
nyohasstium
pushed a commit
to Webgains/superset
that referenced
this pull request
Jan 2, 2025
…he#29790) Co-authored-by: Evan Rusackas <evan@rusackas.com>
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
…he#29790) Co-authored-by: Evan Rusackas <evan@rusackas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MariaDB is not a supported backend for Superset, so it is misleading to suggest it for a development environment. The commit that named MariaDB here is quite old -- I traced it back to a docs overall from 3 years ago, it is likely older than that (the PR was upgrading the docs system) but I stopped there.
There are two other things that could be addressed here:
If someone knows the answer please feel free to suggest the complete fix. But if no one knows, removing the MariaDB mention is an adequate improvement for now.