fix(examples): fix examples uri for sqlite#30277
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #30277 +/- ##
===========================================
+ Coverage 60.48% 83.75% +23.27%
===========================================
Files 1931 534 -1397
Lines 76236 38544 -37692
Branches 8568 0 -8568
===========================================
- Hits 46114 32284 -13830
+ Misses 28017 6260 -21757
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cb32a31 to
1752d00
Compare
rusackas
approved these changes
Sep 16, 2024
rusackas
reviewed
Sep 16, 2024
Member
rusackas
left a comment
There was a problem hiding this comment.
Approved, and restarting E2E failures, but I'm wondering if we need to update this in the tests too.
From superset/.github/workflows/superset-python-integrationtest.yml
test-sqlite:
runs-on: ubuntu-22.04
env:
PYTHONPATH: ${{ github.workspace }}
SUPERSET_CONFIG: tests.integration_tests.superset_test_config
REDIS_PORT: 16379
SUPERSET__SQLALCHEMY_DATABASE_URI: |
sqlite:///${{ github.workspace }}/.temp/superset.db?check_same_thread=true
SUPERSET__SQLALCHEMY_EXAMPLES_URI: |
sqlite:///${{ github.workspace }}/.temp/examples.db?check_same_thread=true
To take it one step further, is there even a case for check_same_thread=true any more, or can we whittle some code away?
mistercrunch
approved these changes
Sep 19, 2024
nyohasstium
pushed a commit
to Webgains/superset
that referenced
this pull request
Jan 2, 2025
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
The PR #25680 fixed the default sqlite connection string for the metastore connection so that it works correctly in an async use case. However, this fix was not applied to the Examples data URI, causing async access to fail.
TESTING INSTRUCTIONS
examplesdatabaseselect 1on theexamplesdatabaseADDITIONAL INFORMATION