Skip to content

fix: fixed Add Metrics to Tree Chart (#29158)#30679

Merged
rusackas merged 9 commits into
apache:masterfrom
SBIN2010:master
Apr 2, 2025
Merged

fix: fixed Add Metrics to Tree Chart (#29158)#30679
rusackas merged 9 commits into
apache:masterfrom
SBIN2010:master

Conversation

@SBIN2010
Copy link
Copy Markdown
Contributor

@SBIN2010 SBIN2010 commented Oct 22, 2024

SUMMARY

Fixed add metrics in the tree chart page

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before:
image
after:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: Fixes Cannot Add Metrics to Tree Chart #29158
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@SBIN2010 SBIN2010 changed the title fix: fixed Add Metrics to Tree Chart (#29158) fix: fixed Add Metrics to Tree Chart (apache#29158) Oct 22, 2024
@SBIN2010 SBIN2010 changed the title fix: fixed Add Metrics to Tree Chart (apache#29158) fix: fixed Add Metrics to Tree Chart (#29158) Oct 22, 2024
Comment thread superset-frontend/src/features/cssTemplates/CssTemplateModal.tsx Outdated
@SBIN2010 SBIN2010 requested a review from justinpark October 30, 2024 06:36
@SBIN2010
Copy link
Copy Markdown
Contributor Author

/korbit-review

Copy link
Copy Markdown

@korbit-ai korbit-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset-frontend/plugins/plugin-chart-echarts/src/Tree/controlPanel.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Documentation
Logging
Error Handling
Readability
Design
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

@rusackas
Copy link
Copy Markdown
Member

Running CI 🤞

SBIN2010 added a commit to SBIN2010/MYsuperset that referenced this pull request Mar 25, 2025
SBIN2010 added a commit to SBIN2010/MYsuperset that referenced this pull request Mar 25, 2025
SBIN2010 added a commit to SBIN2010/MYsuperset that referenced this pull request Mar 26, 2025
@SBIN2010
Copy link
Copy Markdown
Contributor Author

SBIN2010 commented Apr 2, 2025

hi @rusackas , is there anything else you need from me before this can be merged?

Copy link
Copy Markdown
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix, AND for the patience!

@rusackas rusackas merged commit f5d6417 into apache:master Apr 2, 2025
@michael-s-molina michael-s-molina added the v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch label Apr 3, 2025
michael-s-molina pushed a commit that referenced this pull request Apr 3, 2025
@rusackas rusackas mentioned this pull request Apr 3, 2025
3 tasks
michael-s-molina pushed a commit that referenced this pull request Apr 14, 2025
alexandrusoare pushed a commit to alexandrusoare/superset that referenced this pull request Jun 19, 2025
SBIN2010 added a commit to SBIN2010/MYsuperset that referenced this pull request Jul 10, 2025
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugins size/XS v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants