fix: fixed Add Metrics to Tree Chart (#29158)#30679
Merged
Merged
Conversation
justinpark
reviewed
Oct 23, 2024
This reverts commit 35aaeb6.
Contributor
Author
|
/korbit-review |
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/plugins/plugin-chart-echarts/src/Tree/controlPanel.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Documentation ✅ Logging ✅ Error Handling ✅ Readability ✅ Design ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
Member
|
Running CI 🤞 |
SBIN2010
added a commit
to SBIN2010/MYsuperset
that referenced
this pull request
Mar 25, 2025
SBIN2010
added a commit
to SBIN2010/MYsuperset
that referenced
this pull request
Mar 25, 2025
SBIN2010
added a commit
to SBIN2010/MYsuperset
that referenced
this pull request
Mar 26, 2025
Contributor
Author
|
hi @rusackas , is there anything else you need from me before this can be merged? |
rusackas
approved these changes
Apr 2, 2025
Member
rusackas
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the fix, AND for the patience!
michael-s-molina
pushed a commit
that referenced
this pull request
Apr 3, 2025
3 tasks
michael-s-molina
pushed a commit
that referenced
this pull request
Apr 14, 2025
alexandrusoare
pushed a commit
to alexandrusoare/superset
that referenced
this pull request
Jun 19, 2025
(cherry picked from commit f5d6417)
SBIN2010
added a commit
to SBIN2010/MYsuperset
that referenced
this pull request
Jul 10, 2025
9 tasks
This was referenced Jan 15, 2026
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixed add metrics in the tree chart page
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before:


after:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION