Explore view save modal spec#3110
Merged
mistercrunch merged 20 commits intoAug 11, 2017
Merged
Conversation
added 7 commits
July 5, 2017 02:41
will make another commit just to improve test coverage for SaveModal component.
- SaveModal component - URLShortLinkButton
…c' into gg-ExploreViewSaveModalSpec
1 similar comment
Member
|
LGTM, want me to merge it since you don't have write access [yet]? |
Looks like SQLAlchemy has redefined the best practice around pessimistic connection handling.
* Improve the chart type of Visualize in sqllab & Add some css & Fix the link address in the navbar * add vizTypes filter
* [webpack] break CSS and JS files while webpackin' * cleaning up some templates * Fix pylint issue
For Druid set the default port for the broker and coordinator.
Recently in apache@4c3313b I introduced an issue where the order of groupby fields might change. This addresses this issue and will preserve ordering.
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
* split reducer logic for ExploreViewContainer * fix saveModal component and unit tests * revert changes in SaveModal_spec. will make another commit just to improve test coverage for SaveModal component. * improve test coverage for explore view components: - SaveModal component - URLShortLinkButton * remove comment-out code * [bugfix] wrong 'Cant have overlap between Series and Breakdowns' (apache#3254) * [explore] make edit datasource a basic link (apache#3244) * Relying on FAB for font-awesome.min.css (apache#3261) * Modernize SQLA pessimistic handling (apache#3256) Looks like SQLAlchemy has redefined the best practice around pessimistic connection handling. * [webpack] break CSS and JS files while webpackin' (apache#3262) * [webpack] break CSS and JS files while webpackin' * cleaning up some templates * Fix pylint issue * import logging (apache#3264) * [bugfix] preserve order in groupby (apache#3268) Recently in apache@a37a639 I introduced an issue where the order of groupby fields might change. This addresses this issue and will preserve ordering. * Explicitly add Flask as dependancy (apache#3252) * Use sane Celery defaults to prevent tasks from being delayed (apache#3267) * Improve the chart type of Visualize in sqllab (apache#3241) * Improve the chart type of Visualize in sqllab & Add some css & Fix the link address in the navbar * add vizTypes filter * Set default ports Druid (apache#3266) For Druid set the default port for the broker and coordinator. * [explore] Split large reducer logic in ExploreViewContainer (apache#3088) * split reducer logic for ExploreViewContainer * fix saveModal component and unit tests * revert changes in SaveModal_spec. will make another commit just to improve test coverage for SaveModal component. * remove comment-out code * fix merge confilicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add unit tests for Explore view saveModal. These tests are based on sliced reducer (saveModalReducer).